Skip to content

[Merged by Bors] - Cleanup ScheduleBuildSettings #7721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Cleanup ScheduleBuildSettings #7721

wants to merge 2 commits into from

Conversation

james7132
Copy link
Member

Objective

Fix #7440. Fix #7441.

Solution

  • Remove builder functions on ScheduleBuildSettings in favor of public fields, move docs to the fields.
  • Add use_shortnames and use it in get_node_name to feed it through bevy_utils::get_short_name.

@james7132 james7132 added A-ECS Entities, components, systems, and events M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide labels Feb 17, 2023
@github-actions
Copy link
Contributor

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Could you add some context on what users should update when this change get released in a new version of Bevy?
It will be used to help writing the migration guide for the version. Putting it after a ## Migration Guide will help it get automatically picked up by our tooling.

@james7132 james7132 added the C-Usability A targeted quality-of-life change that makes Bevy easier to use label Feb 17, 2023
@alice-i-cecile alice-i-cecile self-requested a review February 17, 2023 02:17
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 17, 2023
@alice-i-cecile alice-i-cecile added this to the 0.10 milestone Feb 17, 2023
@alice-i-cecile
Copy link
Member

alice-i-cecile commented Feb 17, 2023 •
edited
Loading

Merging as trivial.

bors r+

bors bot pushed a commit that referenced this pull request Feb 17, 2023
@james7132
Cleanup ScheduleBuildSettings (#7721)
0425673 
# Objective
Fix #7440. Fix #7441. 

## Solution

 * Remove builder functions on `ScheduleBuildSettings` in favor of public fields, move docs to the fields.
 * Add `use_shortnames` and use it in `get_node_name` to feed it through `bevy_utils::get_short_name`.
@bors
Copy link
Contributor

bors bot commented Feb 17, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Cleanup ScheduleBuildSettings [Merged by Bors] - Cleanup ScheduleBuildSettings Feb 17, 2023
@bors bors bot closed this Feb 17, 2023
myreprise1 pushed a commit to myreprise1/bevy that referenced this pull request Feb 18, 2023
@james7132 @myreprise1
Cleanup ScheduleBuildSettings (bevyengine#7721)
b026299 
# Objective
Fix bevyengine#7440. Fix bevyengine#7441. 

## Solution

 * Remove builder functions on `ScheduleBuildSettings` in favor of public fields, move docs to the fields.
 * Add `use_shortnames` and use it in `get_node_name` to feed it through `bevy_utils::get_short_name`.
@james7132 james7132 deleted the stageless-followup branch February 18, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.10
Development

Successfully merging this pull request may close these issues.

ScheduleBuildSettings should have a use_shortnames field ScheduleBuildSettings should just use public fields
2 participants
@james7132 @alice-i-cecile