-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Set a minimum rust-version #5518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Understandable, but there's a reasonable amount of users who get into Rust and Bevy at the same time, so I think it makes sense to make it clearer for them. (That said, I only noticed a handful of users on Discord get confused by the error, so maybe it's not that common.) ... also, I completely missed that message in the README, whoops. 😅 I haven't had reason to look at it in a while. |
I agree, but a) they typically just download the latest Rust and b) they won't know to look for an MSRV :) |
Cargo refuses to run if the local Rust version is not recent enough, with a more explicit message than the usual "hey you're using nightly features on stable" Maybe we could have the field... but I would like to avoid PR just updating that field because another PR that introduced a dependency on a newer version of Rust forgot to update it. That would mean adding a job to CI actually checking that version |
Error message like in #5520 is so confusing for someone not used to them |
Is there really a need to worry about this on I would expect this to affect people using bevy from It would be nice to add this to the |
If we add the field in the |
It's still possible to remove the line after release during development and adding it back with a new rust version just before releasing a new version. |
Closing in favor of #6852, which automates this further. |
# Objective - Fixes bevyengine#6777, fixes bevyengine#2998, replaces bevyengine#5518 - Help avoid confusing error message when using an older version of Rust ## Solution - Add the `rust-version` field to `Cargo.toml` - Add a CI job checking the MSRV - Add the job to bors
# Objective - Fixes bevyengine#6777, fixes bevyengine#2998, replaces bevyengine#5518 - Help avoid confusing error message when using an older version of Rust ## Solution - Add the `rust-version` field to `Cargo.toml` - Add a CI job checking the MSRV - Add the job to bors
# Objective - Fixes bevyengine#6777, fixes bevyengine#2998, replaces bevyengine#5518 - Help avoid confusing error message when using an older version of Rust ## Solution - Add the `rust-version` field to `Cargo.toml` - Add a CI job checking the MSRV - Add the job to bors
Objective
Trying to compile Bevy on Rust 1.61 or below causes compile errors because
deriving 'Default' on enums is experimental
, which is confusing to users who don't realize that they need to update their toolchain to fix it.Solution
Set
rust-version = 1.62
so that Cargo gives a clearer error.