Skip to content

[Merged by Bors] - Added missing Component Bound to Res<> and ResMut<> #1962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Added missing Component Bound to Res<> and ResMut<> #1962

wants to merge 1 commit into from

Conversation

MinerSebas
Copy link
Contributor

Fixes #1838

@alice-i-cecile
Copy link
Member

I can absolutely see why this is needed. It'll cause interesting things with explicit component derives (#1843), and encourage us to explain resources as "special types of components that aren't associated with a particular entity".

@alice-i-cecile alice-i-cecile added C-Code-Quality A section of code that is hard to understand or change A-ECS Entities, components, systems, and events labels Apr 19, 2021
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 19, 2021
@cart
Copy link
Member

cart commented Apr 19, 2021

bors r+

@cart
Copy link
Member

cart commented Apr 19, 2021

Yeah we already use the Component bound elsewhere for resources. I think this is a perfectly natural extension of that.

bors bot pushed a commit that referenced this pull request Apr 19, 2021
@MinerSebas
Added missing Component Bound to Res<> and ResMut<> (#1962)
e29a899 
Fixes #1838
@bors
Copy link
Contributor

bors bot commented Apr 19, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Added missing Component Bound to Res<> and ResMut<> [Merged by Bors] - Added missing Component Bound to Res<> and ResMut<> Apr 19, 2021
@bors bors bot closed this Apr 19, 2021
@MinerSebas MinerSebas deleted the Res_bound branch April 20, 2021 17:55
ostwilkens pushed a commit to ostwilkens/bevy that referenced this pull request Jul 27, 2021
@MinerSebas @ostwilkens
Added missing Component Bound to Res<> and ResMut<> (bevyengine#1962)
7c0baab 
Fixes bevyengine#1838
@alice-i-cecile alice-i-cecile mentioned this pull request Nov 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf mockersf approved these changes

@inodentry inodentry inodentry approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusing error message if using ResMut with a non-Component type
5 participants
@MinerSebas @alice-i-cecile @cart @mockersf @inodentry