bevy_reflect: Fix TypePath string concatenation
#18609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrGVSV
added
C-Bug
alice-i-cecile
approved these changes
Mar 29, 2025
alice-i-cecile
added
S-Ready-For-Final-Review
MrGVSV
force-pushed
the
mrgvsv/reflect/fix-type-path-string-appending
branch
from
8dc720e to
2725fb2
Compare
mockersf
approved these changes
Mar 29, 2025
mockersf
pushed a commit
that referenced
this pull request
Mar 30, 2025
# Objective Fixes #18606 When a type implements `Add` for `String`, the compiler can get confused when attempting to add a `&String` to a `String`. Unfortunately, this seems to be [expected behavior](rust-lang/rust#77143 (comment)) which causes problems for generic types since the current `TypePath` derive generates code that appends strings in this manner. ## Solution Explicitly use the `Add<&str>` implementation in the `TypePath` derive macro. ## Testing You can test locally by running: ``` cargo check -p bevy_reflect --tests ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #18606
When a type implements
AddforString, the compiler can get confused when attempting to add a&Stringto aString.Unfortunately, this seems to be expected behavior which causes problems for generic types since the current
TypePathderive generates code that appends strings in this manner.Solution
Explicitly use the
Add<&str>implementation in theTypePathderive macro.Testing
You can test locally by running: