Upstream naga_oil
#16491
Upstream naga_oil
#16491
Conversation
tychedelia
added
the
S-Needs-Review
|
Realizing that the squash merge will obliterate the history, unfortunately. |
|
|
||
| match module_set { | ||
| None => { | ||
| // TODO this should be unreachable? |
There was a problem hiding this comment.
This should have an open issue or an unreachable!() with a better comment explaining why
|
|
||
| if self.validate && create_headers { | ||
| // check that identifiers haven't been renamed | ||
| #[allow(clippy::single_element_loop)] |
There was a problem hiding this comment.
There is probably a better way to handle this
| Ok(composable_module) | ||
| } | ||
|
|
||
| // shunt all data owned by a composable into a derived module |
There was a problem hiding this comment.
| // shunt all data owned by a composable into a derived module | |
| /// Shunts all data owned by a composable into a derived module. |
| derived.clear_shader_source(); | ||
| } | ||
|
|
||
| // add an import (and recursive imports) into a derived module |
There was a problem hiding this comment.
| // add an import (and recursive imports) into a derived module | |
| /// Adds an import (and recursive imports) into a derived module. |
| .map_err(|err| err.into()) | ||
| } | ||
|
|
||
| // build required ComposableModules for a given set of shader_defs |
There was a problem hiding this comment.
| // build required ComposableModules for a given set of shader_defs | |
| // Builds the required [`ComposableModules`] for a given set of shader_defs. |
Co-authored-by: Benjamin Brienen <[email protected]>
Co-authored-by: Benjamin Brienen <[email protected]>
Co-authored-by: Benjamin Brienen <[email protected]>
Co-authored-by: Benjamin Brienen <[email protected]>
Co-authored-by: Benjamin Brienen <[email protected]>
Co-authored-by: Benjamin Brienen <[email protected]>
|
Thanks for all the copyediting @BenjaminBrienen! It's very much appreciated. |
If it's interesting to keep the history then someone with privileges could merge it instead? |
| @@ -0,0 +1,203 @@ | |||
| # Bevy Naga Oil | |||
|
|
|||
| Bevy Naga Organized Integration Library (`bevy_naga-oil`) is a crate for combining and manipulating shaders. | |||
There was a problem hiding this comment.
Any reason to mix _ and -? It's already bad that Rust crates use both, but within the same name...
There was a problem hiding this comment.
Oh no that's just a mistake!
BenjaminBrienen
added
S-Waiting-on-Author
naga_oilis a foundational crate for Bevy, but doesn't get enough love from community maintainers. We should include it in the monorepo so that it gets more care and attention. The crate was originally left out of the repo under the "useful to other external users" metric. However, since then, we have included other crates likebevy_colorin the monorepo under and haven't seen uptake from external users that benefitsnaga_oilmaintenence.On the horizon, WESL promises to solve a lot of problems that we currently rely on
naga_oilfor. However, in the meantime, there are a number of important initiatives that would benefit from improvements made tonaga_oil, including future initiatives like upstreamingbevy_hanabiand improvements toAsBindGroupthat may require code generation strategies. Additionally, there are number of outstanding bugs ex. bevyengine/naga_oil#54 that are more likely to get fixed if they live in our issue tracker.Changes
bevy_naga_oilso that its version can be reset to match the rest of the bevy crates.bevy_naga_oil.