Skip to content

Use #[doc(fake_variadic)] for SystemParamBuilder tuple impls. #14962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2024
Merged

Use #[doc(fake_variadic)] for SystemParamBuilder tuple impls. #14962

merged 1 commit into from
Sep 2, 2024

Conversation

chescock
Copy link
Contributor

Objective

Make the documentation for SystemParamBuilder nicer by combining the tuple implementations into a single line of documentation.

Solution

Use #[doc(fake_variadic)] for SystemParamBuilder tuple impls.

image

(This got missed originally because #14050 and #14703 were open at the same time.)

@alice-i-cecile alice-i-cecile added this to the 0.15 milestone Aug 28, 2024
@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-ECS Entities, components, systems, and events X-Uncontroversial This work is generally agreed upon D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 28, 2024
@NiseVoid NiseVoid added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 29, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Sep 2, 2024
Merged via the queue into bevyengine:main with commit f1414cb Sep 2, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killercup killercup killercup approved these changes

@bushrat011899 bushrat011899 bushrat011899 approved these changes

@cBournhonesque cBournhonesque cBournhonesque approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Docs An addition or correction to our documentation D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
0.15
Development

Successfully merging this pull request may close these issues.
6 participants
@chescock @killercup @bushrat011899 @cBournhonesque @NiseVoid @alice-i-cecile