Skip to content

Use observers for removal detection in example #14895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2024
Merged

Use observers for removal detection in example #14895

merged 1 commit into from
Aug 24, 2024

Conversation

janhohenheim
Copy link
Member

@janhohenheim janhohenheim commented Aug 23, 2024 •
edited
Loading

Objective

The removal detection example shows an outdated pattern.

Solution

Show how to do this with observers.

@janhohenheim janhohenheim added A-ECS Entities, components, systems, and events C-Examples An addition or correction to our examples D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 23, 2024
@janhohenheim janhohenheim changed the title Use observers for removal detection Use observers for removal detection in example Aug 23, 2024
TrialDragon
TrialDragon approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@TrialDragon TrialDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on glance, and running the example works.

@alice-i-cecile
Copy link
Member

Part of #13928.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Aug 23, 2024
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 23, 2024
Merged via the queue into bevyengine:main with commit ddf4666 Aug 24, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@TrialDragon TrialDragon TrialDragon approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Examples An addition or correction to our examples D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janhohenheim @alice-i-cecile @TrialDragon