Skip to content

Sync flags in docs.yml with package.metadata.docs.rs #14734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

bash
Copy link
Contributor

@bash bash commented Aug 13, 2024

Objective

This PR is a follow-up to #14703. I forgot to also add the flags from package.metadata.docs.rs to the docs build.

Solution

As discussed on Discord, I added the missing flags to docs.yml.

I also updated rustc-args to properly make use of the array (I think the value has to be either a space-separated string or an array of strings but not an array of space-separated strings 😆)

@bash bash changed the title Sync docs build with package.metadata.docs.rs Sync flags in docs.yml with package.metadata.docs.rs Aug 13, 2024
@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy A-Build-System Related to build systems or continuous integration S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it C-Bug An unexpected or incorrect behavior labels Aug 13, 2024
@alice-i-cecile alice-i-cecile added this to the 0.15 milestone Aug 13, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Aug 14, 2024
Merged via the queue into bevyengine:main with commit a346515 Aug 14, 2024
36 checks passed
@bash bash deleted the fix-dev-docs branch August 14, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Build-System Related to build systems or continuous integration C-Bug An unexpected or incorrect behavior C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants