Skip to content

fix examples after the switch for msaa to a component #14446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Jul 23, 2024

Objective

  • Move Msaa to component #14273 changed MSAA to a component, and broke some examples

  • SSAO needs MSAA to be disabled

    "SSAO is being used which requires Msaa::Off, but Msaa is currently set to Msaa::{:?}",

  • AlphaMode::AlphaToCoverage needs MSAA to be not off to do something

    /// - [`AlphaToCoverage`](AlphaMode::AlphaToCoverage): Object fades in and out
    /// in steps corresponding to the number of multisample antialiasing (MSAA)
    /// samples in use. For example, assuming 8xMSAA, the object will be
    /// completely opaque, then will be 7/8 opaque (1/8 transparent), then will be
    /// 6/8 opaque, then 5/8, etc.

Solution

  • change MSAA in those examples

@mockersf mockersf added A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples labels Jul 23, 2024
@mockersf mockersf added this to the 0.15 milestone Jul 23, 2024
@janhohenheim janhohenheim added D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Jul 23, 2024
@mockersf mockersf added this pull request to the merge queue Jul 24, 2024
Merged via the queue into bevyengine:main with commit 8dc6ccf Jul 24, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants