implement randomize for QueryIter #14407
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
There is no out of the box way to randomize query iteration order. While order is currently not guaranteed, it is still deterministic.
Closes #14393
Solution
Implement a
randomize
method forQueryIter
. This uses a cached sort ofEntity
with its hash as the key.Since the underlying implementation is just a sort, it returns a type alias of
QuerySortedIter
, namedQueryRandomIter
.The same could be done for
QueryManyIter
if #13443 merges.Testing
The example acts as a doc test.
Showcase
Fetch 7 random query items!
let random_items = query.iter().randomize().take(7);