Enable Wayland by default #10792

amytimed · 2023-11-29T02:04:23Z

Objective

Fixes Enable wayland by default #4106
Fixes Enable wayland support in examples. #13340

Solution

Just one commit to add wayland to the default features indeed

Why should it be merged?

The discussion in #4106 seems to be overwhelmingly positive toward adding wayland to the default features, as it can greatly improve user experience for Linux users who use Wayland.

Many of the most popular Linux Desktop Environments (DE) like KDE Plasma Desktop and GNOME have Wayland support. With the release of Plasma 6, Wayland is now used by default, and in GNOME, Wayland has been the default for quite a while now.

With Plasma and GNOME, the most popular Linux DEs, now defaulting to Wayland, it seems like enabling Wayland support would truly indeed positively affect quite a lot of Linux users indeed.

truly

github-actions · 2023-11-29T02:04:34Z

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

i was told not having one was valid toml after passing it through https://www.toml-lint.com/, but github actions hates me

github-actions · 2023-11-29T02:21:38Z

You added a new feature but didn't update the readme. Please run cargo run -p build-templated-pages -- update features to update it, and commit the file change.

github-actions · 2023-11-29T02:22:37Z

You added a new feature but didn't update the readme. Please run cargo run -p build-templated-pages -- update features to update it, and commit the file change.

alice-i-cecile

Based on user feedback on Linux (and my own experiments), I think this is the right default now. Thanks!

tim-blackbird · 2023-11-30T15:56:16Z

Wayland is currently broken for me. It renders one frame and then the window becomes unresponsive or segfaults outright.
Also doesn't work on #10702.

Winit 0.29's own examples run just fine for me on Wayland, though interestingly enough on 0.27 and 0.28 no window appears at all (no crash).

Friz64 · 2023-11-30T17:03:09Z

Wayland is currently broken for me. It renders one frame and then the window becomes unresponsive or segfaults outright.

Do wgpu's examples show the same behavior?

though interestingly enough on 0.27 and 0.28 no window appears at all (no crash)

This, at least, is just because in order for a wayland window to appear, the application needs to have rendered anything, which winit's examples prior to 0.29 did not do.

tim-blackbird · 2023-11-30T17:12:45Z

Do wgpu's examples show the same behavior?

Yes, no segfault's though.

This, at least, is just because in order for a wayland window to appear, the application needs to have rendered anything, which winit's examples prior to 0.29 did not do.

Aha.

Friz64 · 2023-11-30T20:18:40Z

Seems like it's a problem between wgpu and a bug in the latest NVIDIA driver:

Applications using wgpu hang forever on bleeding edge Linux with Nvidia drivers 545.29.06 on GNOME / Wayland gfx-rs/wgpu#4775
Nvidia Driver 545 Breaks Skybox Example on Linux Wayland gfx-rs/wgpu#4689

mockersf · 2023-12-04T19:12:47Z

I think it's worth discussing going one step further, and remove both x11 and wayland as top level features of Bevy, and just always enable them on winit

amytimed · 2023-12-04T21:22:35Z

perhaps but the Customization directly from Bevy features sure is nice indeed truly

Friz64 · 2024-01-22T00:32:59Z

gfx-rs/wgpu#4967 has been merged, which should fix the NVIDIA issue. Unfortunately, it couldn't make it into wgpu 0.19.1 because of breaking API changes: gfx-rs/wgpu#5114 (comment)

inodentry · 2024-02-05T13:14:19Z

I support keeping the cargo features on the Bevy crate to allow for customizability. Do not remove them in favor of unconditionally enabling both on the winit dependency.

I fully support adding Wayland to default features. I have had this position for years.

It is no longer the case that Wayland users are a small minority or early-adopters of new tech. Most Linux distros nowadays default to Wayland. Wayland should be enabled by default to provide the best experience for users.

Also it is no longer the case that XWayland is just fine for everyone and any Wayland users can be assumed to have a reasonably good experience with XWayland anyway. A few years ago, Wayland was mostly being adopted by users on systems that already had great support for X11. Nowadays, there are many platforms and environments where X11 support is neglected (usually available but works poorly) and only Wayland is well-supported. I personally have quite a few "unusual" systems where I have had to build Bevy with Wayland support for it to be usable and not run into weird issues; to name a few: Asahi Linux, WSLg in WSL2, Chromebooks, ...

Modern Linux distros and desktop development focus on Wayland. X11 is bitrotting.

amytimed · 2024-02-06T14:08:13Z

fixed merge conflicts

mnmaita · 2024-05-21T11:24:08Z

@amytimed This also fixes #13340 so maybe you want to add that to the PR description too.

mockersf · 2024-05-21T14:35:58Z

The latest number I could find was 33.68% of linux users on wayland: https://www.gamingonlinux.com/users/statistics/#SessionType-top, so still a minority

Is there an equivalent to xvfb for wayland?

Friz64 · 2024-05-21T15:04:27Z

Is there an equivalent to xvfb for wayland?

Take a look at the xwayland-run project.

gfx-rs/wgpu#4967 has been merged, which should fix the NVIDIA issue. Unfortunately, it couldn't make it into wgpu 0.19.1 because of breaking API changes: gfx-rs/wgpu#5114 (comment)

Even though Nvidia has also fixed this issue on their side with a newer driver, I think we should wait until we have updated to wgpu 0.20 to merge this, to be on the safe side. After that, I don't think there's any big blocker left.

github-actions · 2024-05-21T18:31:55Z

You added a new feature but didn't update the readme. Please run cargo run -p build-templated-pages -- update features to update it, and commit the file change.

Friz64

Now that #13186 was merged, this can be looked at again.

Friz64 · 2024-06-16T18:03:15Z

Cargo.toml

@@ -78,6 +78,8 @@ default = [
  "tonemapping_luts",
  "default_font",
  "webgl2",
+  "wayland",
+  "bevy_debug_stepping",


I don't think you meant to enable the bevy_debug_stepping feature here? @amytimed

benfrankel · 2024-07-19T17:15:32Z

To fix CI, this PR should also add libwayland-dev libxkbcommon-dev to every Install Linux dependencies step.

Friz64 · 2024-07-19T18:09:04Z

I want to draw attention to this issue: gfx-rs/wgpu#5505

Defaulting to Wayland will break Bevy for Wayland users with no access to Vulkan drivers.

I already have a fix cooking for this, but haven't had the time to finish it yet.

janhohenheim · 2024-07-20T21:23:27Z

Removing the X-Controversial label because I think there is a consensus nowadays, based on discussions on GitHub and Discord. Indeed, new users are regularly surprised that Wayland is not already the default. Feel free to add it again if I misread the room :)

alice-i-cecile · 2024-07-20T21:41:13Z

I think "this is blocked on higher quality" is a more accurate read than "this is controversial".

wayland it up by default indeed

208138f

truly

amytimed added 2 commits November 28, 2023 22:06

trailing comma indeed

b23c827

i was told not having one was valid toml after passing it through https://www.toml-lint.com/, but github actions hates me

built templated pages for wayland default feature

001d30e

alice-i-cecile added A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Nov 29, 2023

alice-i-cecile approved these changes Nov 29, 2023

View reviewed changes

alice-i-cecile requested a review from inodentry November 29, 2023 14:49

JMS55 approved these changes Nov 29, 2023

View reviewed changes

alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 29, 2023

alice-i-cecile requested a review from mockersf November 29, 2023 16:05

alice-i-cecile added the X-Controversial There is active debate or serious implications around merging this PR label Nov 30, 2023

udoprog mentioned this pull request Dec 31, 2023

Introduce semaphores and wait on submit gfx-rs/wgpu#4946

Closed

inodentry approved these changes Feb 5, 2024

View reviewed changes

Merge branch 'main' into main

44d31a7

mockersf mentioned this pull request Feb 19, 2024

Install additional dependency "libwayland-dev" bevyengine/bevy_github_ci_template#50

Open

mockersf mentioned this pull request May 12, 2024

Enable wayland support. #13341

Closed

Merge branch 'main' into main

8c65184

MonaMayrhofer mentioned this pull request Jun 14, 2024

Segfault on default app on NixOS/NVIDIA GPU. #13753

Open

Friz64 reviewed Jun 16, 2024

View reviewed changes

alice-i-cecile added S-Blocked This cannot move forward until something else changes and removed S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Jul 19, 2024

benfrankel mentioned this pull request Jul 20, 2024

bevy/wayland feature requires dependencies that may not be installed TheBevyFlock/bevy_new_2d#183

Closed

janhohenheim removed the X-Controversial There is active debate or serious implications around merging this PR label Jul 20, 2024

teohhanhui mentioned this pull request Sep 3, 2024

Enable wayland feature for bevy in dev StarArawn/bevy_ecs_tilemap#556

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable Wayland by default #10792

Enable Wayland by default #10792

amytimed commented Nov 29, 2023 •

edited by alice-i-cecile

Loading

github-actions bot commented Nov 29, 2023

github-actions bot commented Nov 29, 2023

github-actions bot commented Nov 29, 2023

alice-i-cecile left a comment

tim-blackbird commented Nov 30, 2023

Friz64 commented Nov 30, 2023

tim-blackbird commented Nov 30, 2023

Friz64 commented Nov 30, 2023 •

edited

Loading

mockersf commented Dec 4, 2023

amytimed commented Dec 4, 2023

Friz64 commented Jan 22, 2024 •

edited

Loading

inodentry commented Feb 5, 2024

amytimed commented Feb 6, 2024

mnmaita commented May 21, 2024

mockersf commented May 21, 2024

Friz64 commented May 21, 2024 •

edited

Loading

github-actions bot commented May 21, 2024

Friz64 left a comment

Friz64 Jun 16, 2024 •

edited

Loading

benfrankel commented Jul 19, 2024 •

edited

Loading

Friz64 commented Jul 19, 2024

janhohenheim commented Jul 20, 2024 •

edited

Loading

alice-i-cecile commented Jul 20, 2024

Enable Wayland by default #10792

Are you sure you want to change the base?

Enable Wayland by default #10792

Conversation

amytimed commented Nov 29, 2023 • edited by alice-i-cecile Loading

Objective

Solution

Why should it be merged?

github-actions bot commented Nov 29, 2023

github-actions bot commented Nov 29, 2023

github-actions bot commented Nov 29, 2023

alice-i-cecile left a comment

Choose a reason for hiding this comment

tim-blackbird commented Nov 30, 2023

Friz64 commented Nov 30, 2023

tim-blackbird commented Nov 30, 2023

Friz64 commented Nov 30, 2023 • edited Loading

mockersf commented Dec 4, 2023

amytimed commented Dec 4, 2023

Friz64 commented Jan 22, 2024 • edited Loading

inodentry commented Feb 5, 2024

amytimed commented Feb 6, 2024

mnmaita commented May 21, 2024

mockersf commented May 21, 2024

Friz64 commented May 21, 2024 • edited Loading

github-actions bot commented May 21, 2024

Friz64 left a comment

Choose a reason for hiding this comment

Friz64 Jun 16, 2024 • edited Loading

Choose a reason for hiding this comment

benfrankel commented Jul 19, 2024 • edited Loading

Friz64 commented Jul 19, 2024

janhohenheim commented Jul 20, 2024 • edited Loading

alice-i-cecile commented Jul 20, 2024

amytimed commented Nov 29, 2023 •

edited by alice-i-cecile

Loading

Friz64 commented Nov 30, 2023 •

edited

Loading

Friz64 commented Jan 22, 2024 •

edited

Loading

Friz64 commented May 21, 2024 •

edited

Loading

Friz64 Jun 16, 2024 •

edited

Loading

benfrankel commented Jul 19, 2024 •

edited

Loading

janhohenheim commented Jul 20, 2024 •

edited

Loading