Skip to content

Add an examples explanation contribution page #1949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fallible-algebra
Copy link
Contributor

@fallible-algebra fallible-algebra commented Mar 17, 2025

This is a style guide for writing explanations for examples, designed following conversations12 in the discord and the development of doup's docs extraction.

This is an edited version of the hackMD document (which featured 3 examples) that I've posted to the discord a few times, to make it a bit closer to the surrounding contribution guide.

This PR needs some more feedback, there's divergence from the writing docs guide in terms of "who is looking at this" that I'm not sure is necessary, and some things may have been cut from the hackMD doc that shouldn't have been.

Footnotes

  1. (original conversation) https://discord.com/channels/691052431525675048/1316318586247315487/1316384953390600223

  2. (more recent feedback) https://discord.com/channels/691052431525675048/743559241461399582/1331017971862208590

@fallible-algebra fallible-algebra marked this pull request as ready for review March 18, 2025 12:55
@alice-i-cecile alice-i-cecile added X-Controversial There is active debate or serious implications around merging this PR S-Needs-Review A-Contributing-Guide labels Mar 20, 2025
Co-authored-by: Gilles Henaux <[email protected]>
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good content: the advice is clear, helpful and uncontroversial. Sorry for letting this languish!

I'm going to merge this and build on it: I have larger refactors for how we use examples planned :)

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review Ready for a maintainer to consider for merging X-Contentious There are nontrivial implications that should be thought through and removed X-Controversial There is active debate or serious implications around merging this PR S-Needs-Review labels May 9, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue May 9, 2025
Merged via the queue into bevyengine:main with commit 87207f4 May 9, 2025
10 checks passed
@fallible-algebra
Copy link
Contributor Author

Thank you! Looking forward to seeing what's built on it 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Contributing-Guide S-Ready-For-Final-Review Ready for a maintainer to consider for merging X-Contentious There are nontrivial implications that should be thought through
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants