Improve styling of the example/s graphics API callout #1918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
if you're touching this callout, something that I would like is a way to switch between webgl2/webgpu on the same example without going through the index page |
|
Makes sense, I've updated the example page link. |
doup
changed the title
# Conflicts: # sass/components/_example.scss
doup
changed the title
rparrett
approved these changes
Jan 28, 2025
mockersf
reviewed
Jan 28, 2025
Comment on lines
+10
to
+11
| WebGPU is currently only supported on Chrome starting with version 113, and only on desktop. | ||
| If they don't work on your configuration, you can check the WebGL2 examples <a href="/examples">here</a>. |
There was a problem hiding this comment.
for a followup PR: this is no longer true, WebGPU also works on some mobile browsers, and on Safari TP, and Firefox Nightly
We should probably link to something like https://caniuse.com/webgpu for a list or https://browserleaks.com/webgpu so that user can test their browser instead of keeping a list ourselves
mockersf
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Examples
calloutcomponent to style the web graphics API warning.Example
calloutcomponent to style the web graphics API warning.callout--plainmodifier that hides the callout top border.