Skip to content

Release notes for hooks and observers #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 19, 2024

Conversation

alice-i-cecile
Copy link
Member

@alice-i-cecile alice-i-cecile commented Jun 19, 2024

Fixes #1409. Hooks apparently didn't get an issue, but that's fine.

I've decided to tackle these together, focusing on the context of "why and how should I use all these different tools".

Talking to users about the feature, this was the primary confusion / area to clarify: not the API.

@torsteingrindvik
Copy link
Contributor

torsteingrindvik commented Jun 19, 2024

Personally I'd love to read this section and immediately know how to employ hooks and/or observers to a common problem that is an awkward fit without them, but I didn't find one right away.

There seems to be a hint towards this

data (like indexes or hierarchies) exists, even momentarily, in an invalid state

Could a sentence or two about a concrete example of an invalid state (and why it's safer or totally fixed by observers/hooks) be added somewhere? I think that would help me at least

Co-authored-by: Rob Parrett <[email protected]>
Co-authored-by: Christian Hughes <[email protected]>
Co-authored-by: Gonçalo Rica Pais da Silva <[email protected]>
Copy link
Contributor

@iiYese iiYese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions but looks good.

@alice-i-cecile
Copy link
Member Author

@torsteingrindvik does the new example help clarify things for you? :)

@torsteingrindvik
Copy link
Contributor

@torsteingrindvik does the new example help clarify things for you? :)

Yes, thank you!

This example lead me to immediately consider a few components I have in my own apps which contain references to other entities, and now I have a mental hook to consider this new feature for those.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 19, 2024
Merged via the queue into bevyengine:main with commit 0c533a5 Jun 19, 2024
10 checks passed
@alice-i-cecile alice-i-cecile deleted the hooks-and-observers branch June 19, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write release notes for PR #10839: Generalised ECS reactivity with Observers
6 participants