Skip to content

Add release notes for PR #5781: bevy_reflect: Recursive registration #1282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MrGVSV
Copy link
Member

@MrGVSV MrGVSV commented Jun 3, 2024

Fixes #1236

Adds release notes for recursive registration in bevy_reflect.


There's a small amount of nuance that I chose to gloss over such as why we're doing this instead of using inventory or linkme, or which specific things actually rely on these registrations.

I also chose not to go into detail about how this works under the hood via changes to GetTypeRegistration since most users probably don't even know that trait exists.

I did, however, mention that there is still an opportunity for a footgun if a type that's used on its own (i.e. a component, a resource, etc.) is implicitly registered by another type. This is hopefully a lot less likely to occur than forgetting to register an internal type, but still a possibility. This isn't required information, so we can remove it if its too much or detracts from the rest of the feature, but I thought it might still be good to draw attention to.

Anyways, let me know if there's anything that should be added/changed/removed!

@BD103
Copy link
Member

BD103 commented Jun 4, 2024

Could you update the title _release-notes.toml to something like "Recursive type registration"? I think the "bevy_reflect" prefix it left over from the PR title.

Copy link
Member

@BD103 BD103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads well and is a good size, looks good! I have one nit about the title, but it's non-blocking. (We'll catch it later in the final pass.)

alice-i-cecile and others added 2 commits June 4, 2024 14:05
Co-authored-by: Pascal Hertleif <[email protected]>
@alice-i-cecile alice-i-cecile enabled auto-merge June 4, 2024 18:05
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 4, 2024
Merged via the queue into bevyengine:main with commit fd4d936 Jun 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write release notes for PR #5781: bevy_reflect: Recursive registration
4 participants