dorothy-config: fix tests, restore output revised items

config-helper: restore outputting config was updated line to stderr
echo-lines: support --quote flag

commands/config-helper

@@ -422,7 +422,7 @@ function config_helper() (
 	act "${option_args[@]}"
 
 	# we do our own processing, as we need to support multiline matches
-	if test "$UPDATED" = 'yes' -a "$option_quiet" = 'no'; then
+	if test "$UPDATED" = 'yes' -a "$option_quiet" != 'yes'; then
 		echo-style --success="Updated configuration file: $option_file" >/dev/stderr
 	fi
 )

commands/dorothy-config

@@ -9,33 +9,33 @@ function dorothy_config_test() (
 	# remove
 	fs-rm --quiet --no-confirm -- "$DOROTHY/user/config/dorothy-config-testing.bash"
 
-	local invented_packages util_packages expected_stdout expected_stderr
+	local invented_packages util_packages expected_stdout expected_stderr expected_file
 	invented_packages=(
-		"dorothy-config-testing-$(get-random-number)"
-		"dorothy-config-testing-$(get-random-number)"
+		# 0 and 1 prefixes for sorting consistency
+		"dorothy-config-testing-value-0$(get-random-number)"
+		"dorothy-config-testing-value-1$(get-random-number)"
 	)
 	util_packages=(
 		curl
 		ripgrep
 		sd
 	)
+	expected_file="$DOROTHY/user/config/setup.bash"
+
+	# add DOROTHY_CONFIG_TESTING_LIST, ignore stderr as it will vary based on whether choose was used or not
 	expected_stdout="$(__print_lines "${invented_packages[@]}")"
-	expected_stderr="$(
-		cat <<-EOF
-			Moved [curl] from [DOROTHY_CONFIG_TESTING] to [SETUP_UTILS] as [curl].
-			Moved [ripgrep] from [DOROTHY_CONFIG_TESTING] to [SETUP_UTILS] as [ripgrep].
-			Moved [sd] from [DOROTHY_CONFIG_TESTING] to [SETUP_UTILS] as [sd].
-			Updated configuration file: $DOROTHY/user/config/setup.bash
-		EOF
-	)"
-	eval-tester --name='util packages were removed from custom config' --stdout="$expected_stdout" --stderr="$expected_stderr" \
-		-- eval-no-color -- dorothy-config --packages-var='DOROTHY_CONFIG_TESTING' --prefer=public -- "${invented_packages[@]}" "${util_packages[@]}"
+	eval-tester --name='add and remove packages' --stdout="$expected_stdout" --ignore-stderr \
+		-- eval-no-color -- dorothy-config --packages-var='DOROTHY_CONFIG_TESTING_LIST' --prefer=public -- "${invented_packages[@]}" "${util_packages[@]}"
 
-	# remove DOROTHY_CONFIG_TESTING
-	expected_stdout=''
+	# read DOROTHY_CONFIG_TESTING_LIST
+	expected_stdout=$'(\n'"$(echo-lines --quote --indent=$'\t' -- "${invented_packages[@]}")"$'\n)'
+	eval-tester --name='read packages' --stdout="$expected_stdout" --ignore-stderr \
+		-- eval-no-color -- config-helper --file="$expected_file" -- --field='DOROTHY_CONFIG_TESTING_LIST'
+
+	# remove DOROTHY_CONFIG_TESTING_LIST
 	expected_stderr="Updated configuration file: $DOROTHY/user/config/setup.bash"
-	eval-tester --name='custom config was removed' --stdout="$expected_stdout" --stderr="$expected_stderr" \
-		-- eval-no-color -- dorothy-config 'setup.bash' --prefer=public -- --field='DOROTHY_CONFIG_TESTING' --replace=
+	eval-tester --name='remove config' --stderr="$expected_stderr" \
+		-- eval-no-color -- dorothy-config 'setup.bash' --prefer=public -- --field='DOROTHY_CONFIG_TESTING_LIST' --replace=
 
 	echo-style --g1="TEST: $0"
 	return 0
@@ -109,15 +109,15 @@ function dorothy_config() (
 		if test -n "$option_packages_var"; then
 			option_filename='setup.bash'
 		else
-			help "A filename must be provided."
+			help 'A filename must be provided.'
 		fi
 	fi
 
 	# check extension
 	local extension # this is used later too
 	extension="$(fs-extension -- "$option_filename")"
 	if ! [[ $extension =~ ^(bash|zsh|sh|fish|nu)$ ]]; then
-		help "The file extension of [$option_filename] is not yet supported."
+		help 'The file extension of ' --code="$option_filename" ' is not yet supported.'
 	fi
 
 	# =================================
@@ -165,6 +165,9 @@ function dorothy_config() (
 				--field="$option_packages_var" --array="$(__print_lines "${revised_items[@]}" | sort --ignore-case | uniq)" \
 				--field='SETUP_UTILS' --array="$(__print_lines "${SETUP_UTILS[@]}" | sort --ignore-case | uniq)"
 		fi
+
+		# output the revised items, so that the caller has them
+		__print_lines "${revised_items[@]}"
 	}
 
 	function update_configuration {

commands/echo-lines

@@ -198,7 +198,7 @@ function echo_lines() (
 			--suffix=<suffix>
 			    suffix each input with this
 
-			--quoted=<yes/no>
+			--quote=<yes/NO> | --quoted=<yes/NO>
 			    if yes, the arguments will be quoted if necessary
 
 			$(stdinargs_options_help --)
@@ -232,7 +232,7 @@ function echo_lines() (
 		'--no-shrink'* | '--shrink'*)
 			option_shrink="$(get-flag-value --affirmative --fallback="$option_shrink" -- "$item")"
 			;;
-		'--no-quoted'* | '--quoted'*)
+		'--no-quote'* | '--quote'*) # will also support quoted
 			option_quoted="$(get-flag-value --affirmative --fallback="$option_quoted" -- "$item")"
 			;;
 		# forward to stdinargs, however support mixing and matching of our options, with stdinarg options