Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: python support #282

Closed
wants to merge 14 commits into from
Closed

feat: python support #282

wants to merge 14 commits into from

Conversation

liquidiert
Copy link
Contributor

@liquidiert liquidiert commented Oct 28, 2023 •
edited
Loading

  • implemented new Python bebop generator
    • currently does not have tempo and union support
  • implemented Python bebop runtime

solves #56

@liquidiert liquidiert mentioned this pull request Oct 28, 2023
Open
@liquidiert liquidiert changed the title Feature/python support feat: python support Oct 28, 2023
@liquidiert liquidiert marked this pull request as draft October 28, 2023 17:32
@liquidiert
Copy link
Contributor Author

While writing some tests I came over some issues with decoding in the runtime. So I converted the PR to draft for now.

@liquidiert
fix: generator and runtime read
8c05f0b 
  - array types needed obviously append instead of assignment
  - runtime had some read issues for bytes and guid
  - added unit tests
@liquidiert liquidiert marked this pull request as ready for review October 28, 2023 18:21
@liquidiert
feat: bumped py runtime version
7c99b2f
@liquidiert
fix: enum write
9667932 
  - writing enum was faulty, had to call value instead
@andrewmd5
Copy link
Contributor

Hi, currently recovering from the flu so I’ll review once I’m back on my feet. Two things:

  • Squash your commits
  • Ensure you’ve got passing integration test

@liquidiert
Copy link
Contributor Author

liquidiert commented Nov 4, 2023 •
edited
Loading

Hey @andrewmd5 no worries! Regarding your inquiries,

  • should I open a new PR then?
  • meaning I should add some for python?

@andrewmd5
Copy link
Contributor

Hey @andrewmd5 no worries! Regarding your inquiries,

  • should I open a new PR then?
  • meaning I should add some for python?

You shouldn’t need to open a new PR. Just squash and force push to your branch.

And yes, the roundtrip integration test suite will determine if your implementation is correct.

@liquidiert
Copy link
Contributor Author

Okay thanks will do that then :)

@liquidiert liquidiert closed this Nov 5, 2023
@andrewmd5
Copy link
Contributor

Let me know if you need any help with the integration test suite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liquidiert @andrewmd5 @l1qu1d1ert