fix: don't overload toJSON

fixes a recursive stack bug in browsers
betwixt-labs · Feb 10, 2024 · 8dbb630 · 8dbb630
1 parent f89e97a
commit 8dbb630
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/.env b/.env
@@ -1,4 +1,4 @@
-VERSION="3.0.3-beta.2"
+VERSION="3.0.3-beta.3"
 MAJOR=3
 MINOR=0
 PATCH=3
diff --git a/Core/Generators/TypeScript/TypeScriptGenerator.cs b/Core/Generators/TypeScript/TypeScriptGenerator.cs
@@ -325,7 +325,7 @@ public string CompileJsonMethods(Definition definition)
         {
             var builder = new IndentedStringBuilder(0);
             builder.AppendLine(FormatDocumentation("Serializes the current instance into a JSON-Over-Bebop string", null, 0));
-            builder.CodeBlock($"public toJSON(): string", indentStep, () =>
+            builder.CodeBlock($"public stringify(): string", indentStep, () =>
             {
                 builder.AppendLine($"return {definition.ClassName()}.encodeToJSON(this);");
             });
@@ -986,7 +986,7 @@ public override ValueTask<string> Compile(BebopSchema schema, GeneratorConfig co
                                         builder.AppendLine($"invoke: service.{methodName},");
                                         builder.AppendLine($"serialize: {method.Definition.ResponseDefintion}.encode,");
                                         builder.AppendLine($"deserialize: {method.Definition.RequestDefinition}.decode,");
-                                        builder.AppendLine($"toJSON: {method.Definition.ResponseDefintion}.encodeToJSON,");
+                                        builder.AppendLine($"stringify: {method.Definition.ResponseDefintion}.encodeToJSON,");
                                         builder.AppendLine($"fromJSON: {method.Definition.RequestDefinition}.fromJSON,");
                                         builder.AppendLine($"type: MethodType.{RpcSchema.GetMethodTypeName(methodType)},");
                                     }, close: $"}} as BebopMethod<I{method.Definition.RequestDefinition}, I{method.Definition.ResponseDefintion}>);");
@@ -1050,7 +1050,7 @@ public override ValueTask<string> Compile(BebopSchema schema, GeneratorConfig co
                                     builder.AppendLine($"id: {method.Id},");
                                     builder.AppendLine($"serialize: {method.Definition.RequestDefinition}.encode,");
                                     builder.AppendLine($"deserialize: {method.Definition.ResponseDefintion}.decode,");
-                                    builder.AppendLine($"toJSON: {method.Definition.RequestDefinition}.encodeToJSON,");
+                                    builder.AppendLine($"stringify: {method.Definition.RequestDefinition}.encodeToJSON,");
                                     builder.AppendLine($"fromJSON: {method.Definition.ResponseDefintion}.fromJSON,");
                                     builder.AppendLine($"type: MethodType.{RpcSchema.GetMethodTypeName(methodType)},");
                                 });