Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'locales/' folder to package.json #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jamesdorfman
Copy link

@jamesdorfman jamesdorfman commented Aug 10, 2021

The npm documentation for this package includes the example

var instance = timeDelta.create({
  locale: 'en' // default
});

However, the locales/ folder is not currently shipped with the package, so the above code will fail.
This MR fixes this.

The package needs this folder in order to correctly operate.
@slavafomin
Copy link
Member

Hello! Have you tried to use more modern/maintained library? I'm a bit curious why have you selected this slightly outdated (6 years) one :)

@slavafomin
Copy link
Member

@jamesdorfman I've dramatically refactored the library today. Please, try to download the latest version and tell me if it works for you. Thanks.

@jamesdorfman
Copy link
Author

Hi, I could not find a more modern library to do this.
I just needed to find the difference between two dates, in English (not numerically).
But, if you have others you are aware of that do the same thing, I would happily check them out :)

Thanks for the update! I'll give it a go and let you know

@slavafomin
Copy link
Member

I could not find a more modern library to do this.

I see. The good thing is that I've updated it then.

What is your target platform? Are you using it in browser or Node.js?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants