automatically take screenshots when integration specs fail #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adipasquale
force-pushed
the
refactor/spec-failures-screenshots
branch
from
351f667
to
6218ef9
Compare
adipasquale
changed the title
jjf21
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linked to https://trello.com/c/yibIcLXq/601-fix-randomly-failing-feature-specs
this PR makes integration specs take a screenshot (HTML + png) upon each failure.
Locally:
On CircleCI :
cf https://github.com/mattheworiordan/capybara-screenshot/
and mattheworiordan/capybara-screenshot#211 (comment)
and https://circleci.com/docs/2.0/artifacts/
I also fixed the
store_test_resultsdirective that was pointing to the wrong directory. It lets us see a formatted view of failing tests on CircleCI: