Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubberquads presets for the squirrel35 and team-rates #466

Merged
merged 8 commits into from
May 17, 2024

Conversation

VolkerGoeschl
Copy link
Contributor

High everyone!
This PR is my first one to this repo ->I hope everything is in order. Otherwise lent me know so future PRs will be less of a hazzle.

Copy link
Member

@limonspb limonspb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High everyone! This PR is my first one to this repo ->I hope everything is in order. Otherwise lent me know so future PRs will be less of a hazzle.

Hello Sir.
looking pretty good.

A few notes:
for new presets that never been used we recommend to put
#$ STATUS: EXPERIMENTAL

you should also add:
#$ PARSER: MARKED
since you are using html in the description

For presets that set sliders position you should add
simplified_tuning apply at the end.
This is a CLI command that recalculates sliders to the actual PID/filter values. THat way you also don't have to list all the PID/filter values the slider changes.

Its recommended to use 4 spaces as a tab, not 2

i see your rates title is #$ TITLE: AOS Rates
is that expected title?

This option MUST be unchecked in the rates preset:

    #$ OPTION BEGIN (CHECKED): profile 1
        rateprofile 0
    #$ OPTION END

This option MUST be unchecked:

#$ OPTION BEGIN (CHECKED): I want to arm upside down
    set small_angle = 180
#$ OPTION END

because its not part of the tune, its safety/personal preference.

Can't set set vbat_sag_compensation = 80 in the tune, because, again, its personal preference.

So far all i could find.

@VolkerGoeschl
Copy link
Contributor Author

Dear Ivan!
First things first: I'm not a Sir. Although I'm 45 I would preferere a slightly more casual adressing ("shit pilot" will do fine also I'm not sure I earned it).
Second: Thank you very much for having a look - It's very much appreciated!
Now for the actual problems in my "code":
#$ STATUS: EXPERIMENTAL nope We have flown well over 2k packs on those settings on dozends of rigs so I'm pretty confident they will work
#$ PARSER: MARKED I'll fix it
simplified_tuning apply thanks- I'll fix it is there a similar command for filters as well?

Its recommended to use 4 spaces as a tab, not 2

done some python? ;-)

#$ TITLE: AOS Rates upsi
profile selection and small_angle I'll fix it!
set vbat_sag_compensation = 80 Is this negotiable? Since the best pack for keeping the weight of those rigs under 250g is a HV this is definitly needed. Otherwise you would get Dterm-trilling for the first 30-60 seconds or have an undertuned rig for the second half of each pack.

@limonspb
Copy link
Member

limonspb commented May 16, 2024

Dear Ivan! First things first: I'm not a Sir. Although I'm 45 I would preferere a slightly more casual adressing ("shit pilot" will do fine also I'm not sure I earned it). Second: Thank you very much for having a look - It's very much appreciated! Now for the actual problems in my "code": #$ STATUS: EXPERIMENTAL nope We have flown well over 2k packs on those settings on dozends of rigs so I'm pretty confident they will work #$ PARSER: MARKED I'll fix it simplified_tuning apply thanks- I'll fix it is there a similar command for filters as well?

Its recommended to use 4 spaces as a tab, not 2

done some python? ;-)

#$ TITLE: AOS Rates upsi profile selection and small_angle I'll fix it! set vbat_sag_compensation = 80 Is this negotiable? Since the best pack for keeping the weight of those rigs under 250g is a HV this is definitly needed. Otherwise you would get Dterm-trilling for the first 30-60 seconds or have an undertuned rig for the second half of each pack.

Hehe :)

About #$ STATUS: EXPERIMENTAL - i understand that lots of people might be running your settings. But making a preset from the settings can cause extra errors. So i have no doubt in your settings, but there is a danger from making a preset, syntax, forgetting to copy-paste something etc. That's why new preset files should be EXPERIMENTAL at first for some time. It's like a release-candidate stage, since presets are going online right away after approval.

simplified_tuning apply does the magic for all active sliders, PIDs and filters.

set vbat_sag_compensation = 80 - fair point, it also affects the tune...

@VolkerGoeschl
Copy link
Contributor Author

Thanks for clarifying the experimental status -> I totally agree (and changed it)

Copy link
Member

@limonspb limonspb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple more notes.

ON a side note, you can also create (if you want) a tune preset thats a combination of TUNE + FILTERS. Thats allowed in TUNE category. I would imagine most people use both of your presets most of the time anyways.

presets/4.5/rates/rubberquads_team_rates.txt Outdated Show resolved Hide resolved
presets/4.5/rates/rubberquads_team_rates.txt Outdated Show resolved Hide resolved
presets/4.5/rates/rubberquads_team_rates.txt Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@limonspb limonspb merged commit 8754ca4 into betaflight:master May 17, 2024
1 check passed
@limonspb
Copy link
Member

nice, now plz check your presets in configurator. Make any fixes if needed in a new PR :)

@VolkerGoeschl
Copy link
Contributor Author

Thank you so much for guiding me through this!
And to quote Botgrinder: Next time will be better ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants