-
-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rubberquads presets for the squirrel35 and team-rates #466
rubberquads presets for the squirrel35 and team-rates #466
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
High everyone! This PR is my first one to this repo ->I hope everything is in order. Otherwise lent me know so future PRs will be less of a hazzle.
Hello Sir.
looking pretty good.
A few notes:
for new presets that never been used we recommend to put
#$ STATUS: EXPERIMENTAL
you should also add:
#$ PARSER: MARKED
since you are using html in the description
For presets that set sliders position you should add
simplified_tuning apply
at the end.
This is a CLI command that recalculates sliders to the actual PID/filter values. THat way you also don't have to list all the PID/filter values the slider changes.
Its recommended to use 4 spaces as a tab, not 2
i see your rates title is #$ TITLE: AOS Rates
is that expected title?
This option MUST be unchecked in the rates preset:
#$ OPTION BEGIN (CHECKED): profile 1
rateprofile 0
#$ OPTION END
This option MUST be unchecked:
#$ OPTION BEGIN (CHECKED): I want to arm upside down
set small_angle = 180
#$ OPTION END
because its not part of the tune, its safety/personal preference.
Can't set set vbat_sag_compensation = 80
in the tune, because, again, its personal preference.
So far all i could find.
Dear Ivan!
done some python? ;-)
|
Hehe :) About
|
Thanks for clarifying the experimental status -> I totally agree (and changed it) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple more notes.
ON a side note, you can also create (if you want) a tune preset thats a combination of TUNE + FILTERS. Thats allowed in TUNE category. I would imagine most people use both of your presets most of the time anyways.
nice, now plz check your presets in configurator. Make any fixes if needed in a new PR :) |
Thank you so much for guiding me through this! |
High everyone!
This PR is my first one to this repo ->I hope everything is in order. Otherwise lent me know so future PRs will be less of a hazzle.