-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mutual exclusive gyro alignment #644
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -120,5 +120,4 @@ | |
|
||
#define GYRO_1_SPI_INSTANCE SPI1 | ||
#define GYRO_1_ALIGN CW0_DEG_FLIP | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. total mismatch |
||
#define GYRO_1_ALIGN_YAW 2700 | ||
#define DEFAULT_ALIGN_BOARD_YAW -45 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -106,4 +106,3 @@ | |
#define FLASH_SPI_INSTANCE SPI3 | ||
#define GYRO_1_SPI_INSTANCE SPI1 | ||
#define GYRO_1_ALIGN CW0_DEG_FLIP | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ! |
||
#define GYRO_1_ALIGN_PITCH 1800 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -114,4 +114,3 @@ | |
#define PINIO1_CONFIG 129 | ||
#define PINIO1_BOX 40 | ||
#define GYRO_1_ALIGN CW90_DEG | ||
#define GYRO_1_ALIGN_YAW 900 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -123,8 +123,6 @@ Details: https://github.com/crteensy/yolo-chonker/tree/as-built-20230303 | |
|
||
#define DEFAULT_GYRO_TO_USE GYRO_CONFIG_USE_GYRO_1 | ||
#define GYRO_1_ALIGN CW0_DEG_FLIP | ||
#define GYRO_1_ALIGN_PITCH 1800 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. (this one is correct - 0deg + flip) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would think to remove |
||
#define GYRO_2_ALIGN CW0_DEG_FLIP | ||
#define GYRO_2_ALIGN_PITCH 1800 | ||
|
||
#define ENSURE_MPU_DATA_READY_IS_LOW |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is wrong - only remove cases where GYRO_1_ALIGN and GYRO_1_ALIGN_YAW do match. These mismatches must be handled individually (or left to trigger error)