Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gps color #4241

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Fix gps color #4241

merged 3 commits into from
Nov 8, 2024

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Nov 4, 2024

Fixes status column color

[status]
unused => red
USED => green

[quality]
no signal => red
searching => red
locked => orange
fully locked => green

Circus before:

Screenshot from 2024-11-04 15-27-50

Clarity after:

image

@haslinghuis haslinghuis added this to the 11.0 milestone Nov 4, 2024
@haslinghuis haslinghuis self-assigned this Nov 4, 2024
Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit 3e1f3de
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/672904aa3eacbe0008d1d242
😎 Deploy Preview https://deploy-preview-4241.dev.app.betaflight.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nerdCopter
Copy link
Member

is "locked" relatively good? maybe locked should be yellow since it is closer to green than orange? IDK, just asking.

@haslinghuis
Copy link
Member Author

Following 🚦 (red - orange - green), but maybe this is more clear:

image

@nerdCopter
Copy link
Member

[...] maybe this is more clear:

maybe so... less visual-noise.
@ctzsnooze ?

Copy link

sonarqubecloud bot commented Nov 4, 2024

@haslinghuis haslinghuis merged commit d277924 into betaflight:master Nov 8, 2024
8 checks passed
@haslinghuis haslinghuis deleted the fix-gps-color branch November 8, 2024 11:29
demvlad pushed a commit to demvlad/betaflight-configurator that referenced this pull request Nov 14, 2024
* Fix gps color

* Refactor and ease usedColor

* [chore]Refactor lexical scoping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

3 participants