-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue3 upgrade #4169
Vue3 upgrade #4169
Conversation
✅ Deploy Preview for origin-betaflight-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ❤️
what CLI commands should i invoke for testing? |
@haslinghuis I just realized I used the wrong branch, I'm gonna have to redo my PR |
Wait, I misread and it wants the branch to NOT be named master, so we're good to go here. |
@nerdCopter |
I get an error on loading the home page
Can anyone confirm this is expected? |
Not an issue with this PR. Needs experimental flags being enabled #4024 (comment) Obvious some code (likely porthandler) is bypassing betaflight-configurator/src/js/protocols/bluetooth.js Lines 26 to 31 in 643b484
|
High! Thanks for this PR, it's always welcome an update to more modern versions. |
Here seems to be the reason that reactivity is missing, Vue 2 data object was deep reactivity, and Vue 3 is shallow reactivity: https://v3-migration.vuejs.org/breaking-changes/data-option#migration-strategy
I'm working through options to get this going again |
I haven't figured it out and will redo the PR when it's ready |
Upgrades to Vue3
Upgrades Storybook to Version 8
Updates ESLint rules
NOTE: Currently Storybook loads without errors but many components are not looking like you would expect, so there's more to do to make a robust Storybook experience.