-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aesthetic CLI dropdown menu #4073
Conversation
Darker background of CLI dropdown menu instead of white BG with yellow font.
✅ Deploy Preview for origin-betaflight-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This affects too to the light theme? |
Upon testing it wasn't affecting the light theme for me, are you saying it is affecting the light theme or asking if it does make changes to the light theme? |
Asking. I'm out of the computer and I can't test it on mobile 😉 |
When testing it wasn't making a change on the light theme for myself. However looking at it in the light theme mode pretty sure this may benefit both. I am biased to dark theme as the brightness affects my eyes. This would be entirely down to light theme users though if they would want to request changes or the main developers. |
Not at this moment. If it does not break it and it's usable it's ok for me. The light theme needs a complete "rework" in the colours because some of them have very bad contrast. It's a known issue that I hope we can fix before the next release. |
Darker background of CLI dropdown menu instead of white BG with yellow font.
Example of white dropdownb menu with yellow font.
to something more in keeping with Betaflight colors.