Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aesthetic CLI dropdown menu #4073

Merged
merged 1 commit into from
Jun 29, 2024
Merged

Conversation

Six6siX
Copy link
Contributor

@Six6siX Six6siX commented Jun 28, 2024

Darker background of CLI dropdown menu instead of white BG with yellow font.

Example of white dropdownb menu with yellow font.
Screenshot_2024-06-23_at_17 02 43

to something more in keeping with Betaflight colors.
Screenshot 2024-06-28 at 22 03 02

Darker background of CLI dropdown menu instead of white BG with yellow font.
Copy link

netlify bot commented Jun 28, 2024

Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit 9e45001
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/667f2605ac645500080cf00b
😎 Deploy Preview https://deploy-preview-4073.dev.app.betaflight.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@haslinghuis haslinghuis added this to the 11.0 milestone Jun 28, 2024
@McGiverGim
Copy link
Member

This affects too to the light theme?

@Six6siX
Copy link
Contributor Author

Six6siX commented Jun 29, 2024

This affects too to the light theme?

Upon testing it wasn't affecting the light theme for me, are you saying it is affecting the light theme or asking if it does make changes to the light theme?

@McGiverGim
Copy link
Member

Asking. I'm out of the computer and I can't test it on mobile 😉

@Six6siX
Copy link
Contributor Author

Six6siX commented Jun 29, 2024

Asking. I'm out of the computer and I can't test it on mobile 😉

When testing it wasn't making a change on the light theme for myself. However looking at it in the light theme mode pretty sure this may benefit both.

Screenshot 2024-06-29 at 09 10 22

I am biased to dark theme as the brightness affects my eyes. This would be entirely down to light theme users though if they would want to request changes or the main developers.

@McGiverGim
Copy link
Member

This would be entirely down to light theme users though if they would want to request changes or the main developers.

Not at this moment. If it does not break it and it's usable it's ok for me. The light theme needs a complete "rework" in the colours because some of them have very bad contrast. It's a known issue that I hope we can fix before the next release.

@haslinghuis haslinghuis merged commit c4fd801 into betaflight:master Jun 29, 2024
6 checks passed
@Six6siX Six6siX deleted the sfpv_bfconf branch June 29, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

4 participants