Fix payload not init on error case; Fix payload not overwriting primi…

…tives (rgstephens#50)
betafcc · Dec 5, 2023 · c44e808 · c44e808
1 parent 36374fa
commit c44e808
Show file tree

Hide file tree

Showing 4 changed files with 100 additions and 5,186 deletions.
diff --git a/README.md b/README.md
@@ -11,6 +11,7 @@ A NodeRed node to execute GraphQL Queries.
 
 | Vers  | Changes       |
 | ----- | -------------------------------------------------------- |
+| 2.1.3 | Fix payload not init on error case; Fix payload not overwriting primitives (#50) |
 | 2.1.2 | Fix payload init issue |
 | 2.1.0 | Bearer Token Authentication |
 | 2.0.1 | Update dependencies (`axios` & `mustache`), fix node-red scorecard issues |

diff --git a/graphql.js b/graphql.js
@@ -2,8 +2,9 @@ module.exports = function(RED) {
   // https://github.com/axios/axios
   var axios = require("axios");
   var mustache = require("mustache");
+  var isPlainObject = require("lodash.isplainobject");
 
-  var vers = "2.1.2";
+  var vers = "2.1.3";
 
   function isReadable(value) {
     return typeof value === 'object' && typeof value._read === 'function' && typeof value._readableState === 'object'
@@ -151,7 +152,7 @@ module.exports = function(RED) {
                 shape: "dot",
                 text: RED._("graphql.status.success")
               });
-              if (!node.msg.payload) node.msg.payload = {};
+              if (!isPlainObject(node.msg.payload)) node.msg.payload = {};
               node.msg.payload.graphql = response.data.data; // remove .data to see entire response
               if (node.showDebug){
                 node.msg.debugInfo = {
@@ -189,6 +190,7 @@ module.exports = function(RED) {
         .catch(function(error) {
           RED.log.debug("error:" + error);
           node.status({ fill: "red", shape: "dot", text: "error" });
+          if (!isPlainObject(node.msg.payload)) node.msg.payload = {};
           node.msg.payload.graphql = { error };
           node.error("error: " + error);
           node.send([null, node.msg]);