Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST 1.0 - Add fetching and setting of transaction CustomFields #368

Open
wants to merge 6 commits into
base: 5.0-trunk
Choose a base branch
from

Conversation

puck
Copy link
Contributor

@puck puck commented Oct 20, 2023

These patches allow CustomFields to be set on transactions via the REST API. Thread on rt-devel is here: https://lists.bestpractical.com/pipermail/rt-devel/2016-March/012530.html

It is a resurrection of #178 which I expect was automatically closed because the branch name started with 4.2. This patch set applies cleanly against 4.4-trunk and 5.0-trunk.

It is also the patchset from #183 which was closed in favour of 178.

Cheers,
Andrew

@cbrandtbuffalo
Copy link
Member

We have generally been trying not to make any changes to REST 1.0 code, leaving it in place for stability and backward compatibility. REST 2 supports transaction CFs, but I assume you're adding on to something that already uses REST 1?

@puck
Copy link
Contributor Author

puck commented Oct 24, 2023

Haha, understandable.

I was looking at what patches we were still carrying locally. We're no longer using the REST 1.0 API, so I was planning on dropping these patches, but recall that others have been using them, so thought I'd refresh the branch.

@cbrandtbuffalo
Copy link
Member

OK, cool. In the interest of stability for REST 1.0 and also keeping this code available, I'll plan to leave this branch here for anyone who might need it. If the patches apply cleanly now, they should continue to do so if we leave the REST 1.0 code alone (except for any security issues).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants