Avoid duplicates of TicketType/ObjectType criteria for txn searches

The duplicates could happen when you navigate pages on txn search result page.
bestpractical · Nov 16, 2023 · 2be1b0f · 2be1b0f
1 parent 16991a0
commit 2be1b0f
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 7 deletions.
diff --git a/lib/RT/Interface/Web.pm b/lib/RT/Interface/Web.pm
@@ -5806,11 +5806,16 @@ sub PreprocessTransactionSearchQuery {
 
     my @limits;
     if ( $args{ObjectType} eq 'RT::Ticket' ) {
-        @limits = (
-            q{TicketType = 'ticket'},
-            qq{ObjectType = '$args{ObjectType}'},
-            $args{Query} =~ /^\s*\(.*\)$/ ? $args{Query} : "($args{Query})"
-        );
+        if ( $args{Query} !~ /^TicketType = 'ticket' AND ObjectType = '$args{ObjectType}' AND (.+)/ ) {
+            @limits = (
+                q{TicketType = 'ticket'},
+                qq{ObjectType = '$args{ObjectType}'},
+                $args{Query} =~ /^\s*\(.*\)$/ ? $args{Query} : "($args{Query})"
+            );
+        }
+        else {
+            @limits = $args{Query};
+        }
     }
     else {
         # Other ObjectTypes are not supported for now

diff --git a/t/web/search_txns.t b/t/web/search_txns.t
@@ -29,9 +29,14 @@ diag "Query builder";
 
     $m->follow_link_ok( { id => 'page-results' } );
     $m->title_is('Found 3 transactions');
+    $m->get_ok($m->uri . '&RowsPerPage=1');
+    $m->follow_link_ok( { text => '2' } );
+    $m->follow_link_ok( { text => '3' } );
+
+    $m->follow_link_ok( { text => 'Edit Search' }, 'Build Query' );
+    my $form = $m->form_name('BuildQuery');
+    is($form->find_input('Query')->value, qq{TicketType = 'ticket' AND ObjectType = 'RT::Ticket' AND ( TicketId = 1 )});
 
-    $m->back;
-    $m->form_name('BuildQuery');
     $m->field( TypeOp      => '=' );
     $m->field( ValueOfType => 'Create' );
     $m->click('AddClause');