Adjust styles and remove Chrome popup

berzniz · Apr 10, 2020 · 8456f8c · 8456f8c
1 parent 101b09f
commit 8456f8c
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 10 deletions.
diff --git a/src/js/components/options/index.jsx b/src/js/components/options/index.jsx
@@ -21,8 +21,8 @@ class Options extends React.Component {
     this.setState(await StorageSync.get())
   }
 
-  isChrome() {
-    return typeof browser === "undefined"
+  isChrome () {
+    return typeof browser === 'undefined'
   }
 
   render () {
@@ -32,11 +32,11 @@ class Options extends React.Component {
         <div className='text-center'>
           <h1>Better Pull Request</h1>
           <p>
-            Thanks for using Better Pull Request {this.isChrome() ? "Chrome" : "Firefox"} Extension! 🎉
+            Thanks for using Better Pull Request {this.isChrome() ? 'Chrome' : 'Firefox'} Extension! 🎉
           </p>
           <p>
-            If you're enjoying this extension, please <a href={this.isChrome() ? chromeStoreUrl : firefoxStoreUrl} target="_blank">rate it
-            on the {this.isChrome() ? "Chrome" : "Firefox"} Store</a>.
+            If you're enjoying this extension, please <a href={this.isChrome() ? chromeStoreUrl : firefoxStoreUrl} target='_blank'>rate it
+            on the {this.isChrome() ? 'Chrome' : 'Firefox'} Store</a>.
           </p>
         </div>
         <div>

diff --git a/src/js/components/tree/index.jsx b/src/js/components/tree/index.jsx
@@ -128,7 +128,7 @@ class Tree extends React.Component {
 
   onOptions () {
     let browserApi = window.chrome
-    if (typeof browser !== "undefined") {
+    if (typeof browser !== 'undefined') {
       browserApi = browser
     }
     window.open(browserApi.runtime.getURL('options.html'))

diff --git a/src/manifest.chrome.json b/src/manifest.chrome.json
@@ -28,9 +28,6 @@
       "css": []
     }
   ],
-  "browser_action": {
-    "default_popup": "options.html"
-  },
   "options_page": "options.html",
   "web_accessible_resources": ["options.html"],
   "icons": {

diff --git a/src/manifest.firefox.json b/src/manifest.firefox.json
@@ -37,7 +37,7 @@
     "default_popup": "options.html"
   },
   "options_ui": {
-		"chrome_style": true,
+    "chrome_style": true,
     "page": "options.html"
   },
   "web_accessible_resources": ["options.html"],