This repository has been archived by the owner on Nov 2, 2022. It is now read-only.
Use Version Compare Function to perform check #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the function version() allows the check to work correctly on Ubuntu 20.04 when the samba version has -Ubuntu in the string returned by the sed command.
|
It would be great to see this merged. Fixes #62. |
|
I agree, just stumbled on the same issue #64 with the newest ubuntu. Can this fix be merged? It seems ok. |
azmodude
added a commit
to azmodude/ansible-role-samba
that referenced
this pull request
Mar 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the function version() allows the check to work correctly on Ubuntu 20.04 when the samba version has -Ubuntu in the string returned by the sed command.