Bugs importing text columns containing commas or newlines, added MysqlLogger #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…newlines in text columns, add a MysqlLogger Logger implementation.
|
Hopefully you guys are still following this project and will merger this in - it probably slows parsing down, but makes for MUCH more reliable imports. |
…t, then run grails package-maven
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into some major bugs when importing CSV files that contain commas or newlines in text columns - the existing parsing just did simple splitting on commas and newlines and did not take into account the totally valid possibility that such character might exist between quotes in text columns. I also added a MysqlLogger implementation, since I needed a persistent import audit trail.
I created a version V0.1.4 that addresses these issues.