-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small patch to make akephalos work on windows #53
base: master
Are you sure you want to change the base?
Conversation
You're great, noniq. I hope this one gets pulled soon. |
I tried the patch on a Windows XP machine. It runs (which is what I needed, of course). It still seems to have trouble closing the remote process. Apparently, the cause is line 65 in remote_client.rb:
Maybe this could be replaced with a check for the OS, and possibly use the kill() method from win32-process (see: https://rubyforge.org/docman/view.php/85/707/README.html). Already a very worthy patch even without fixing this. |
Is there anything I can do to help get this integrated? I run cucumber on windows regularly using Capybara/SeleniumWD, and would like to switch to something headless. |
+1 - this is currently blocking me too |
@nusco: I played around with this today: Based on your suggestion it's possible to kill the remote (ruby) process, see https://gist.github.com/1044475 |
Unfortunately I don't. :( Like many people here, I'm not really a Windows person - I just happen to have a lot of customers using Windows, so I had to goof around on Google looking for a solution. I think it boils down to get the id of the Java process on launch, right? |
Another thing I've noticed in trying to get this to run on Cygwin/Win7 is that the "rescue Errno::ECONNREFUSED" big in the self.responsive? function is not catching Win7's new/different error: |
taskkill can be used to kill the ruby process and the child java process that it creates.
fairly new to ruby so no idea if this is the best solution. |
We recently replaced our development machines with Macs, so this is no longer a issue for us – I leave the pull request open however, as it is at least a small improvent to the status quo :-) |
The change in the call to
IO.popen
inremote_client.rb
is taken from https://github.com/bernerdschaefer/akephalos/issues#issue/18/comment/485887 .Additionally I had to replace
":"
withFile::PATH_SEPARATOR
in two places inbin/akephalos
.With these changes, running a cucumber feature using akephalos works (tested on Windows 7). It leaves the command prompt in kind of a weird state, however. Not sure yet what's causing this – for now I just close and reopen the command prompt window, if necessary.