forked from Cal-CS-61A-Staff/seating
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Smarter Import/Export #64
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage for unit tests for Python 3.10
|
Coverage for unit tests for Python 3.12
|
Coverage for e2e tests for Python 3.11
|
Coverage for e2e tests for Python 3.10
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
==========================================
+ Coverage 39.50% 44.24% +4.73%
==========================================
Files 27 27
Lines 1777 1962 +185
==========================================
+ Hits 702 868 +166
- Misses 1075 1094 +19 ☔ View full report in Codecov by Sentry. |
Coverage for e2e tests for Python 3.12
|
Coverage for unit tests for Python 3.11
|
Coverage for unit tests for Python 3.10
|
Coverage for e2e tests for Python 3.10
|
Coverage for unit tests for Python 3.12
|
Coverage for e2e tests for Python 3.11
|
Coverage for e2e tests for Python 3.12
|
Coverage for unit tests for Python 3.11
|
Coverage for unit tests for Python 3.10
|
Coverage for e2e tests for Python 3.11
|
Coverage for e2e tests for Python 3.10
|
Coverage for unit tests for Python 3.12
|
Coverage for e2e tests for Python 3.12
|
Coverage for unit tests for Python 3.11
|
Coverage for unit tests for Python 3.12
|
Coverage for unit tests for Python 3.10
|
Coverage for e2e tests for Python 3.10
|
Coverage for e2e tests for Python 3.11
|
Coverage for e2e tests for Python 3.12
|
Coverage for unit tests for Python 3.10
|
Coverage for unit tests for Python 3.11
|
Coverage for unit tests for Python 3.12
|
Coverage for e2e tests for Python 3.10
|
Coverage for e2e tests for Python 3.12
|
Coverage for e2e tests for Python 3.11
|
Coverage for unit tests for Python 3.11
|
Coverage for unit tests for Python 3.10
|
Coverage for unit tests for Python 3.12
|
Coverage for e2e tests for Python 3.11
|
Coverage for e2e tests for Python 3.10
|
Coverage for e2e tests for Python 3.12
|
Coverage for unit tests for Python 3.10
|
Coverage for unit tests for Python 3.11
|
Coverage for e2e tests for Python 3.10
|
Coverage for e2e tests for Python 3.11
|
Coverage for unit tests for Python 3.12
|
Coverage for e2e tests for Python 3.12
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #59
Import
Whenever you import student from a sheet, you now have these options
Revalidate Existing Seat Assignments
True
: Preferences might get updated after this import. chooseTrue
to revalidate the existing seat assignment (if any) against the new preferences. If not valid, assigment would be set to null.False
: no revalidation.Student Basic Info Update Import Strategy
/Student Preference Update Import Strategy
MERGE
: New values would be used if present, unless new value is blank or not provided, in which case old values are used.OVERWRITE
: New values would be used. If blank, then the existing values would be nullified too.IGNORE
: only old values are used.Seat Assignment Import Strategy
IGNORE
: don't import seat assigment, even though it might be present in the import sheet.FORCE
: always import seat assignment, ignoring any preferences, existing or updated.REVALIDATE
: import the new seat assignment only if it conforms to the existing/updated preferencesNew Row Strategy
APPEND
: append in new studentsIGNORE
: don't append in new students that are not already existingMissing Row Strategy
REMOVE
: renove students that are missing from the new sheetIGNORE
: dont' renove students that are missing from the new sheetExport
Now imports and exports should be symmetric. In the sense that exported sheet could directly be used for importing again, with no information loss whatsoever.
The exported sheet would contain these columns
['name', 'email', 'student id', 'canvas id', 'session name', 'seat name', 'emailed', 'room id', 'seat id']
, plus the student preferences columns (true, false).Edit: Now supports exporting
public seat url
.Manual entry
Now supports entering student roster csv!
Todos
Allow user to apply a global preference/avoid to all students at import time?
That preferences might be imported as appending to the existing ones or overwrite all existing ones.