Fix: Unhandled bug when batch deleting students by emails (#60)

berkeley-cdss · Mar 13, 2024 · af44e29 · af44e29
1 parent 52d99af
commit af44e29
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/.gitignore b/.gitignore
@@ -111,4 +111,4 @@ axe/
 gcp-service-account-credentials.json
 
 # bootstrap
-setup.sh
+setup*.sh
diff --git a/server/views.py b/server/views.py
@@ -630,7 +630,7 @@ def delete_students(exam):
         if not form.use_all_emails.data:
             emails = [x for x in str_set_to_set(form.emails.data) if x]
             students = Student.query.filter(
-                Student.email.in_(emails) & Student.exam_id == exam.id)
+                Student.email.in_(emails) & (Student.exam_id == exam.id))
         else:
             students = Student.query.filter_by(exam_id=exam.id)
         deleted = {student.email for student in students}