Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Instant toolbar updates #199

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Instant toolbar updates #199

wants to merge 7 commits into from

Conversation

marcobarbosa
Copy link
Contributor

Some refactoring here. Before this toolbar was done pretty quickly.

  • Removed selection logic since instant toolbar doesn't depend on it
  • Don't show/hide the toolbar multiple times when clicking
  • Show the toolbar on the parent element instead on the event coordinates
  • Abstracted some functions
  • Add and remove a CSS class before showing and hiding it. Very useful for a CSS3 transition.

Also in the link plugin:

  • Close the toolbar when showing the dialog (shouldn't you do that?)
  • Bigger dialog height

Take a look. I'm not sure if I'm supposed to include the build but it's there anyway.

astjohn added a commit to astjohn/hallo that referenced this pull request May 7, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant