-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate log statistics #64
Conversation
I don't understand actions well enough to know if this is feasible, but it might even be a good idea to have a system where it prompts the user to run a full simulation before making a merge, and provides the template command to run, i.e.
with the |
yeah the 'actions way' of doing this would be to run it automated... but for that we'd need a super mini example as we don't have access to a gpu at least not either free or trivially 😆 |
Maybe we can just have a script, outside of the action setup, that fills out the command with e.g. the commit. Regardless this is a low priority item, so I'd say don't worry about it for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adjusted everything / added requested defaults etc, should be mergeable
Adds a class for Logging Statistics instead of using a Loss for everything to make the interface a bit more expressive:
Please double check the changes in the objectives _weighted_params function, as it's not sufficiently covered by the test 🙃