Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rl config #50

Merged
merged 15 commits into from
Oct 30, 2024
+213 −117
Merged

Fix rl config #50

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
1e9b410
fix: import path for moved utils file
fabioseel Oct 2, 2024
8682dcd
fix: adjust config paths and fix load brain methods
fabioseel Oct 2, 2024
fc0bdd7
add example rl configs
fabioseel Oct 25, 2024
90e9391
fix: change optimizer referencing in to_sf_cfg
fabioseel Oct 25, 2024
86088a4
fix: add brain factory method as interface
fabioseel Oct 25, 2024
98eea38
fix: back and forth of config loses DictConfig . accessing
fabioseel Oct 25, 2024
d908f28
fix: update config after change in model
fabioseel Oct 28, 2024
a559a12
fix: wrong reference in create_brain
fabioseel Oct 28, 2024
6161013
fix: sample_factory needs optimizer in lowercase
fabioseel Oct 28, 2024
d1dabb5
autofix by ruff on changed files
fabioseel Oct 28, 2024
30f3a2d
bugfix: lint.sh with just --fix works now
fabioseel Oct 28, 2024
447d4fe
fix: merge isinstance calls, add/remove return statements etc
fabioseel Oct 28, 2024
39c4ba6
fix: optimizer has to be provided, remove check
fabioseel Oct 28, 2024
3478315
fix: split complex function
fabioseel Oct 28, 2024
7168e02
doc: mark rl analysis stuff as deprecated
fabioseel Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: sample_factory needs optimizer in lowercase
@fabioseel
fabioseel committed Oct 28, 2024
commit 6161013da9a8b091b9f874a89046cbe16c1bc111
2 changes: 1 addition & 1 deletion retinal_rl/rl/sample_factory/sf_framework.py
View file
Original file line number Diff line number Diff line change
@@ -110,7 +110,7 @@ def to_sf_cfg(self, cfg: DictConfig) -> Config:
self._set_cfg_cli_argument(sf_cfg, "env", cfg.dataset.env_name)
self._set_cfg_cli_argument(sf_cfg, "input_satiety", cfg.dataset.input_satiety)
self._set_cfg_cli_argument(sf_cfg, "device", cfg.system.device)
optimizer_name = str.split(cfg.optimizer.optimizer._target_, sep='.')[-1]
optimizer_name = str.lower(str.split(cfg.optimizer.optimizer._target_, sep='.')[-1])
self._set_cfg_cli_argument(sf_cfg, "optimizer", optimizer_name)

self._set_cfg_cli_argument(sf_cfg, "brain", OmegaConf.to_object(cfg.brain))