Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat CI Pipeline #4

Merged
merged 50 commits into from
Oct 11, 2024
Merged

Feat CI Pipeline #4

merged 50 commits into from
Oct 11, 2024

Conversation

fabioseel
Copy link
Contributor

@fabioseel fabioseel commented Oct 10, 2024

Added features

Adds three CI pipelines:

  • code check using pylint
    • on every commit when a .py file is changed (but only on the changed py files)
    • on pull requests (only on changed py files)
  • singularity container build
    • runs when a commit changes the .def or periodically once a month (2 at night the first of the month)
  • scan if configs parse and models can be created (currently only for classification models)
    • runs on pull requests

Discussion / Future Extensions

Also, the singularity file is cached for faster execution (will be deleted if not used for a week, but can be pulled again then).
However, we might want to discuss whether this would be enough and we drop the package storage and just built it again if needed. Rough time estimates:

  • load cached container: 30-45s
  • pull container: 60-90s
  • build container: 8-10 mins

This should be enough for now. In the future I plan some extensions however:

  • extend code check using pyright to ensure typing
  • extend scan for rl configs

To be done before merge:

  • discuss cache / storage / build stuff
  • discuss whether any of the future extensions should be implemented already now
  • make cache available across branches (just realized now that this seems not to be the case)

@fabioseel fabioseel requested a review from alex404 October 10, 2024 14:56
@fabioseel fabioseel marked this pull request as draft October 10, 2024 15:00
@fabioseel fabioseel marked this pull request as ready for review October 11, 2024 09:36
@alex404 alex404 merged commit 96d1647 into master Oct 11, 2024
3 checks passed
@alex404 alex404 deleted the feat-ci-pipeline branch October 11, 2024 11:38
Copy link
Contributor

@alex404 alex404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take your word for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants