Skip to content

Commit

Permalink
fix(?): code check comparison to master
Browse files Browse the repository at this point in the history
make init/get singularity action do only the caching/pulling
  • Loading branch information
fabioseel committed Oct 10, 2024
1 parent 40a09a8 commit 77f3121
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 13 deletions.
15 changes: 8 additions & 7 deletions .github/workflows/code_check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:

jobs:
init:
uses: ./.github/workflows/setup.yml
uses: ./.github/workflows/get_singularity.yml
with:
singularity_image: oras://ghcr.io/berenslab/retinal-rl:singularity-image-latest
sif_file: retinal-rl_singularity-image-latest.sif
Expand All @@ -19,12 +19,13 @@ jobs:
needs: init
runs-on: ubuntu-latest
steps:
- name: list directory
run: ls
- uses: actions/checkout@v4
- name: list directory
run: ls
- name: Checkout code
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Fetch all branches
run: git fetch --all
- name: Run Pylint
run: |
singularity exec ~/singularity_images/retinal-rl_singularity-image-latest.sif \
pylint $(git diff --name-only origin/master HEAD -- '*.py')
pylint $(git diff --name-only origin/master...HEAD -- '*.py')
4 changes: 3 additions & 1 deletion .github/workflows/config_scan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ on: [pull_request,workflow_dispatch]

jobs:
init:
uses: ./.github/workflows/setup.yml
uses: ./.github/workflows/get_singularity.yml
with:
singularity_image: oras://ghcr.io/berenslab/retinal-rl:singularity-image-latest
sif_file: retinal-rl_singularity-image-latest.sif
Expand All @@ -12,7 +12,9 @@ jobs:
needs: init
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Scan classification config
run: |
cp -r resources/config_templates/* config/
singularity exec ~/singularity_images/retinal-rl_singularity-image-latest.sif \
python main.py -m +experiment=cifar10-class-recon command=scan system.device=cpu
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Pull Singularity container & Setup Repository
name: Get Singularity Container

on:
workflow_call:
Expand All @@ -13,10 +13,7 @@ on:
jobs:
init:
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v4

steps:
- name: Setup Apptainer
uses: eWaterCycle/setup-apptainer@v2
with:
Expand Down

0 comments on commit 77f3121

Please sign in to comment.