fix: env variables seem poorly supported, removed that

berenslab · Oct 10, 2024 · 70229c3 · 70229c3
1 parent 2840e46
commit 70229c3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/.github/workflows/code_check.yml b/.github/workflows/code_check.yml
@@ -8,19 +8,15 @@ on:
     branches:
       - main
 
-env:
-  singularity_image: oras://ghcr.io/berenslab/retinal-rl:singularity-image-latest
-  sif_file: retinal-rl_singularity-image-latest.sif
-
 jobs:
   init:
     uses: ./.github/workflows/setup.yml
     with:
-      singularity_image: ${{ env.singularity_image }}
+      singularity_image: oras://ghcr.io/berenslab/retinal-rl:singularity-image-latest
 
   lint:
     needs: init
     runs-on: ubuntu-latest
     steps:
     - name: Run Pylint
-      run: singularity exec ${{ env.sif_file }} pylint $(git diff --name-only origin/master HEAD -- '*.py')
+      run: singularity exec retinal-rl_singularity-image-latest.sif pylint $(git diff --name-only origin/master HEAD -- '*.py')
diff --git a/.github/workflows/config_scan.yml b/.github/workflows/config_scan.yml
@@ -1,19 +1,15 @@
 name: Scan Configs
 on: [pull_request,workflow_dispatch]
 
-env:
-  singularity_image: oras://ghcr.io/berenslab/retinal-rl:singularity-image-latest
-  sif_file: retinal-rl_singularity-image-latest.sif
-
 jobs:
   init:
     uses: ./.github/workflows/setup.yml
     with:
-      singularity_image: ${{ env.singularity_image }}
+      singularity_image: oras://ghcr.io/berenslab/retinal-rl:singularity-image-latest
 
   scan:
     needs: init
     runs-on: ubuntu-latest
     steps:
     - name: Scan classification config
-      run: singularity exec ${{ env.sif_file }} python main.py -m +experiment=cifar10-class-recon command=scan system.device=cpu
+      run: singularity exec retinal-rl_singularity-image-latest.sif python main.py -m +experiment=cifar10-class-recon command=scan system.device=cpu