Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[build] Basic fixes and extentions to build scripting
1. Fixed various syntax issues, including an unquoted variable in conditional test (Debug or Release log file name), superfluous backslashes, spaces between errorlevel tests and tested functions, MSBuild syntax consolidaiton, prefixing FOR do commands with @, etc. 2. Unwrapped nested IF statements to ensure no jumping out of loops or other unexpected behaviours. 3. Updated usage, including Win11 target and explanation regarding analysis builds (build.bat only). 4. Added analysis build specific variables CODEQL_FAILED and SDV_FAILED to init area (build.bat only). 5. Refactored fail code, removing return failure detection in favour of in-line failure detection. 6. Updated labels to use snake style notation. 7. Refactored end of build_arch function to avoide "goto :eof" and instead use ":build_arch_done" to ensure POPD occurs and ":build_arch_skip" to check for success before ending the local environment (build.bat only). 8. Do conditional (if exists) removal of sdv and codeql_db folders (build.bat only). 9. Additional commenting and stdout output (logging). 10. Remove superfluous newline spacing. 11. Removed packaging folder from build per PRs virtio-win#1209 and virtio-win#1224 (buildAll.bat only). 12. Consolidated exiting function (whether success or fail) to :leave (buildAll.bat only). Split from PR virtio-win#1212. .,ueeeeeu, e$$$$$P?$$$$$b :$$$$" '$$$$c $$$$ $$$$c $$$6 $$$$$ $$$F $$$$" $$$F $$$F $$$$ $$$F $$$$ J$$F .ccCCCCCCCCc,. ?$$$ $$$$$$e ,CCCCCCCCCCCCCCCCCCc :$$$ `$$$$$" CCCCCCCCCCCCCC" CCCCCC. `$$$. CCCCCCCCCCC" .,d.`CCCCCC. $$$t .,uuuuu,. <CCC . `"",$$$$$$L CCCCCC ?$$$ ,HHHHHHHHHHHHHb, CCC $$$$$$$$$P"""" `CCCCC `$$$ 4F"" .,uuuuuuu,,,,. `CC '=- "$$$="""$$r C><C `$$$, zuHF""`.,,,,,,. ""??HH `CC bue$:$$$$bd$$$ C ? C $$$$ -=='.ee???$eeeec,,,.`=. `C $$$$ $$P???$$$ C cC ?$$$ ,H"" .e$P"""?heeee,,."" .'P .cc-=<Cc, cC'CC' `$$$ HH jF $$$b,/"""cd$$..,,) \ dP". .,cCCCP u `$$$. .HHH H':F $$$du,$$$$ ' ";l CCCCCCCCCCCCC'.$$ $$$h HHHF H H "$$$$$F d$ 4$$ H ,z "?CCCCCCCCP J$$ :: $ ?$$$ HHH'jF.H % $P" ...'" u$ J' .d$$$$F . ....zd$P" :::d$ :$$$ HHH H HF %%,%%" %' dH j$$$$$$$$ ::: ::::: $$ ? HF %%%%%.%. " % JHf :: $$$$$$$$$. :::::::::::::::d$$ .::::::::::::: '%%%%%%%%%%/ H" ::::: $$$$$$$$$$ ::::::::::::::d$$$ :::'``````````'::: `%%%%%%%%% JH dH :::::: ?$$$$$$$$$ `:::::::::::: $$$$ ..:::::::::::::::. %%%%%%/', H" H","" `::: ?$$$$$$$$$" :::::::::::`$$$$$ ... . ::: : . `: `eeeee;".F -.H dHHHHc. $$$$$F"`.=" `:::::::` '?$$$$ ::::: .ze$eu . `: =uuuu/"z".H" HHHHHHHHHHe. "" e$$$$$$b :::: ee,. '$$ ' z$$$$$$$$$$$$$ `.zeed?"".dHF HHHHHHHHHHHHHH $$$$$beeem ': ec,"$$$$ ' : 4$$$ . $$$$?? beeeeeedHF"".HHHHHF"" _,,.. `$$$$cze= ':,,`"$$$$$$$ : $$$$$b,,d$F , .HHF""".,zeHHHHF" ,i!"` .,;i!!!i;. ?$bee` ::`""9$$$$$$$ : $$$$$$$$$$$L., c,,eeHHHHHHHHF ,i!' .;!!!!!!!!!!!!!!. . ::::""??$$$$$$$ J$$$$$??$,`'". .HHHHHHHHHHHH" ,!!'.i!!!!!!!!!!!!!!!!!! \ ::::: d$bc."??$ "$$$$$$h .; .HHHHHHHHHHHF" ,!!',! !!!!!!''''` '''<!!i ? :::: d$$$$$ :$ "$$$$$$$F uHHHHHHHHHHH" ,!! ,!! !!!" !i ::: $$$$$ $$$ """ "HHHHHHHHH ,!!',!!!! !" .d$$$$ezece$$$, ! ::: d$$$$$' ...: :::::::: 3HHHHH" ,!!',!!!!! d$$$$$$$$$$$$$$$t > ::: d$$$$$ :::: ::` .::::: HHHHF ,!!' !!!!!! 9$$P""""?$$$$$$$$" ! ; `:: $$$$$$ : ::: .::::::::: ?HH" ,!!! !!!!!!! 3$$$.``''$$$F - ; ! ! `: $$$$$$`:: :: .::::::::::: H" ,!!!'<!!!!!!!i $$$$$$$$$$ teeJ' . ! ! : d$$$$$$`:: ` .:::::::::::::: " ,!!!! <!!!!!!!! $$$$$$P??'?$$ ! !i ` d$$$$$$L:: ::::::::::: `<!!! !!!!!!!!' '$$u,"""" ,' . ; ! `!. d$$$$$$$:: .::::::: aeeee$$$$$$e <!!!!!!!' '.^$$$$$$F' ; !! !!, $$$$$$$$`: ::::::::::`""777d$$$$$$u !!!!!! ' $$ee...e% < , !! `!!i$$$$$$$L : ``````::`` d$$$$$ ?$$$b `!!!' , . $$$$$$$$ . . !! !!!,$$$$$$$ : eccec,. ,zd$$$$$$$$$$>$L; !' ; , """"""" ; \ `! !!!,?$$$$$ ` $$$$$$$$d$$$$$$$$$P""""` . . ' !!!!!!!!! . `; ` ` !, !!i"$$$$ ` $$$$$$$$$$$$$$$$$F i!!' ,' .. .. ``!!! ! `; \ ` `\`!!.$$$L >>>"""""""??$$$$k ==" !!' ' , , d$$" u":". !! ! \ `; ` i!i,`!!, ?$F $$$$UUU$$$$u,"?$$$ =" r ' $F4 ".$$LJ 3$L !!,` ', \ !!i,.`!i.`!.$ $$$$$$$$$$$ec. d$$$ f '" $$F4.$"zP"$$b."b !!,` '! . :!!!!!!i.`!i """```"=??he, ?$$$b ,i'! ! d$$$$$d$b$$$$$$F?$ `!='' ..... `!,!i ,,,, ,,, ::: $$$$ `!i 'i" $$$$$$$$$$$$$$$c`" d$$$$$$bc, "?$$$$$$$.!,`!i $$$' $$$ '::::: '$$$> !!!!! `?$$$$$$$$$$$$F d$$$$$$$$$$F,u.'$$$$$$c!i`! : .$$$"x ::::: $$$ i!!!!!, $. ``"""""" .,z$$$P"?$$$",ed$$$b $$$$$$i!!! $e $$$" $R ::::: 3$$ !!!!!!!,`$$bd"uer .dP"""?$$. ?y, "4$$$$$$,`$$$$Fi!!! " d$$$ :::::::: )$$ !!!!!!i `$$bc . "?bey,. `d$$e `$$$$F $PP"i!!!! d$$F $r :::::: $$$ )!!!!!! `$$$L".W. "?$by,`"d$$$$$$c $$$" .eeeeu '! J$$" : .:::: . """ !!!!!!!i. `??$ .,._ `"3$$$$$$$$$b,,,d$$$$$$$$c "$" ::::::' : !!!!!!!!!!!!i;;i! ueee. `"?$$$$$$$$$$$$$$$$$$$$$$$$$$$F :.::::::: `:: :: <!!!!!!!!!!!!> z$$$$$$$$$$$be..`'<<<??$$$$$$$$$$$$$$$F.i :::::::: : :: :: !!!!!!!!!!!':$$$$$$$$$$$$$$$$$$beeeeeee,. ```"`,i!!! :::::: ::: ::: : !!!!!!!!!' . ""??$$$$$$$$$$$$$$PF"""'` .,,;;ii!!!!!!!! ::::: ::: `:: :: `!!!!!!! !!!!!i,,,,... .....,,,;;;ii!!!!!!!!!!!!!!!!! ::: :: :::: :: :: !!!!!' ,!!!!!!!!!!!!",!!!!!!!!!!!!!!!!!,`!!!!!!!!!!!!! :` ':: :::: :: :: !!!!' !!!!!!!!!!!!! ,!!!!!!!!!!!!!!!!!!!i!!!!!!!!!!!!! .:: :: :::: :: :: !!!' !!!!!!!!!!!!'.!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! :::: :: :::: :: :: !!' !!!!!!!!!!!!',!!!!''.,;;;;;,.`'''''''`!!!!!!!!!!!! :::: :' :::: `: `: !'.!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!i;,,..`'<!!!!! ::: :' ::::: :: :: .!!!! .!!!!!!!i!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!i;;,, ' ::`.: .:''` .. . `` . ' , '!!!!i!!!!>:!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! ...\..>\\.\\.\\\\ ,/ |, ''```''`<<''<'<<<<<<<!!!!!!!!!!!!!!!!!!!! `\>/`\\\>\%`%%"./'%..\=///,%//,,/', ,/'' ,/ , `'''''''''''''''''!!!!!!! //>;>;\.""./';./>.`\- |`/./'','./|'"/`\\</%/'//%','::::::::::::::::!!!!!!' \.:\'.'///'">>>`,`/'. '. ,` ,/',/',|%//<</,'<^< -=-<'\\'-::``,::'.!!!'` . /==>'/%.////;.//>>,/,;,.-.`\`,..\`<.\\=\\-^//=/<<\\%'- ' .,::` ..:' '`.::: '/'/''/'/>.''</>(\<|/%<%///>\`\%</>>\\%\\\>/\'\\\\< `.,'' ..::'`.:.::::'` /',/"><|,/','/'>,/,/'>/|/>\\`|"\|<``\`\"" \<```.,,'`` ..::::..:::: ::: ::::::::::::::::::::::...::::::::::::::::::::''` ...::::::::::::::: ::: ............................................. .:::::::::::::::::::: ::: ::::::::::::::::::::::::::::::::::::::::::::: :::::::::::::::::::::::: . Signed-off-by: benyamin-codez <[email protected]>
- Loading branch information