2979 - Metadata template and download should be consistent #4273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillNigel23
force-pushed
the
2979-metadata-template-and-download-should-be-consistent
branch
from
161641a
to
9ea4f00
Compare
WillNigel23
force-pushed
the
2979-metadata-template-and-download-should-be-consistent
branch
from
9ea4f00
to
dd8fa30
Compare
benwbrum
requested changes
Nov 6, 2024
There was a problem hiding this comment.
On testing, @saracarl and I noticed these things that need to be changed:
- We should move the metadata upload processing to a background task, since it takes a very very long time for large collections.
- Some fields which are internal to FromThePage (work slug, document set) are now appearing in the About tab for a work if we update them. These should not be processed the same way that non-metadata fields are, and should not appear in About.
app/models/metadata.rb
Outdated
| '*FromThePage ID*', | ||
| 'FromThePage Title', | ||
| 'FromThePage Description', | ||
| 'FromThePage Identifier', |
There was a problem hiding this comment.
"FromThePage Identifier" is actually an identifier that's user-entered and refers to an ID in some kind of external system. (I think we call it External ID in the database).
Let's change this to Identifier, since we don't want people to think that we use this for internal logic.
|
Before upload: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.