Updating logical date millis logic (#71)

benwatson528 · May 5, 2021 · 61489fc · 61489fc
1 parent e3ee750
commit 61489fc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/main/java/uk/co/hadoopathome/intellij/viewer/fileformat/ParquetFileReader.java b/src/main/java/uk/co/hadoopathome/intellij/viewer/fileformat/ParquetFileReader.java
@@ -111,7 +111,7 @@ public String getLogicalTypeName() {
     }
 
     public String fromLong(Long millisFromEpoch, Schema schema, LogicalType type) {
-      return Instant.ofEpochSecond(millisFromEpoch).toString();
+      return Instant.ofEpochMilli(millisFromEpoch).toString();
     }
 
     public Long toLong(String timestamp, Schema schema, LogicalType type) {

diff --git a/src/test/java/uk/co/hadoopathome/intellij/viewer/fileformat/ParquetFileReaderTest.java b/src/test/java/uk/co/hadoopathome/intellij/viewer/fileformat/ParquetFileReaderTest.java
@@ -76,7 +76,7 @@ public void testDateLogicalType() throws IOException {
     assertThat(records).hasSize(5);
     String firstRecord = records.get(0);
     assertThat(firstRecord)
-        .contains("{\"received_at\": \"2020-08-27T19:41:44Z\", \"name___string\": \"Tressa\"");
+        .contains("{\"received_at\": \"1970-01-19T12:02:37.304Z\", \"name___string\": \"Tressa\"");
   }
 
   private List<String> readRecords(String fileName, int numRecords) throws IOException {