chore(sse): refactor sse utils with cursor #4356
Conversation
bojiang
changed the title
| "\n\n" in chunk | ||
| or chunk | ||
| and chunk[0] == "\n" | ||
| and last_chunk | ||
| and last_chunk[-1] == "\n" |
There was a problem hiding this comment.
Is this part needed? Could we always just append the buffer until we see \n\n and then update the cursor?
There was a problem hiding this comment.
Chunking may happen right in the middle of \n\n and break down it into two chunks
There was a problem hiding this comment.
Yeah, if that happens maybe we just simply wait for the next chunk to arrive?
There was a problem hiding this comment.
I don't think so. You may take a closer look at the process here, or edit as you want and check if the unit test can still pass.
There was a problem hiding this comment.
Right, i understood what you wrote. I think we can just have while '\n\n' in chunks condition, and that will solve two problem at once:
- The scenario you mentioned, where its chunked between two
\ncharacter, it will simply wait for the next chunk to enter the buffer then we will have the full delimiter again. - Multiple events in the same chunk, it will then yield multiple times before it receives the next chunk into buffer
|
open from another branch |
What does this PR address?
Fixes #(issue)
Before submitting:
guide on how to create a pull request.
pre-commit run -ascript has passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.