Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chord): fix bad logic for checking if dataset project changed #544

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

davidlougheed
Copy link
Member

@davidlougheed davidlougheed commented Sep 27, 2024

adds a test which catches this (and fixes some assert patterns in that test file.)

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.90%. Comparing base (06699e2) to head (4606a8b).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #544   +/-   ##
========================================
  Coverage    90.90%   90.90%           
========================================
  Files          127      127           
  Lines         4893     4893           
  Branches       693      693           
========================================
  Hits          4448     4448           
  Misses         299      299           
  Partials       146      146           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@gsfk gsfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected, thanks (I didn't look at the tests)

@davidlougheed davidlougheed merged commit 9c666ba into develop Sep 27, 2024
7 checks passed
@davidlougheed davidlougheed deleted the fix/chord/patch-dataset branch September 27, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants