Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proper permissions for schema endpoints #542

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

davidlougheed
Copy link
Member

these should be properly public.

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.99%. Comparing base (3c7e196) to head (b12fd9a).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #542   +/-   ##
========================================
  Coverage    90.99%   90.99%           
========================================
  Files          131      131           
  Lines         4939     4939           
  Branches       705      705           
========================================
  Hits          4494     4494           
  Misses         299      299           
  Partials       146      146           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@v-rocheleau v-rocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. There are still decorators using the AllowAny permission class, should they be replaced as well?

@davidlougheed
Copy link
Member Author

There are a lot of endpoints (search mostly) I haven't thought through yet, so for now I'm leaving them as-is - these were already included in the authz middleware allow-list, but didn't have the proper permissions to be served.

@davidlougheed davidlougheed merged commit fe3cb86 into develop Sep 18, 2024
7 checks passed
@davidlougheed davidlougheed deleted the fix/schema-permissions branch September 18, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants