Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experiment type Viral WGS #442

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

noctillion
Copy link
Contributor

This PR include changes in experiment schema to add Viral WGS to experiment_type

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #442 (48422c4) into develop (0c420d8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #442   +/-   ##
========================================
  Coverage    86.43%   86.43%           
========================================
  Files          129      129           
  Lines         5161     5161           
  Branches       680      680           
========================================
  Hits          4461     4461           
  Misses         520      520           
  Partials       180      180           
Files Coverage Δ
chord_metadata_service/experiments/schemas.py 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will need to also bump the version number in pyproject.toml before releasing, but this looks good to me.

@noctillion noctillion merged commit 74a8aa2 into develop Sep 29, 2023
7 checks passed
@davidlougheed davidlougheed deleted the patch/add_experiment_type_viralwgs branch October 2, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants