Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing id field to disease autocomplete #436

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

gsfk
Copy link
Member

@gsfk gsfk commented Sep 18, 2023

disease autocomplete was returning "label" field twice instead of "id" and "label"

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #436 (1aa9f55) into develop (4ab3c55) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #436   +/-   ##
========================================
  Coverage    86.42%   86.42%           
========================================
  Files          129      129           
  Lines         5156     5156           
  Branches       680      680           
========================================
  Hits          4456     4456           
- Misses         520      521    +1     
+ Partials       180      179    -1     
Files Changed Coverage Δ
...etadata_service/phenopackets/autocomplete_views.py 91.42% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gsfk gsfk merged commit c9042c1 into develop Sep 18, 2023
7 checks passed
@davidlougheed davidlougheed deleted the fixes/disease-autocomplete-id branch September 22, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants