Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/download dats #423

Merged
merged 8 commits into from
Aug 7, 2023
Merged

Features/download dats #423

merged 8 commits into from
Aug 7, 2023

Conversation

noctillion
Copy link
Contributor

@noctillion noctillion commented Aug 2, 2023

This pull request introduces the action dats in the DatasetViewSet class. This action is designed to fetch a specific DATS file associated with a given dataset. Referenced in Feature #1373

Changes:
Added a new @action decorator to handle requests for individual datasets.
Included "identifier" property in datasets provenance metadata

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #423 (602fba2) into develop (e454c55) will increase coverage by 0.01%.
The diff coverage is 85.71%.

@@             Coverage Diff             @@
##           develop     #423      +/-   ##
===========================================
+ Coverage    86.26%   86.28%   +0.01%     
===========================================
  Files          129      129              
  Lines         5207     5213       +6     
  Branches       693      693              
===========================================
+ Hits          4492     4498       +6     
  Misses         537      537              
  Partials       178      178              
Files Changed Coverage Δ
chord_metadata_service/restapi/api_views.py 95.00% <ø> (ø)
...etadata_service/restapi/candig_authz_middleware.py 58.20% <0.00%> (ø)
chord_metadata_service/chord/api_views.py 98.24% <100.00%> (+0.20%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very small test tweaks, other than that looks good!

chord_metadata_service/chord/tests/test_api.py Outdated Show resolved Hide resolved
chord_metadata_service/chord/tests/test_api.py Outdated Show resolved Hide resolved
chord_metadata_service/chord/tests/test_api.py Outdated Show resolved Hide resolved
@noctillion
Copy link
Contributor Author

Thanks for your review and insights!

Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@noctillion noctillion merged commit 8899dda into develop Aug 7, 2023
6 of 7 checks passed
@davidlougheed davidlougheed deleted the features/download-dats branch August 23, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants