-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13] fix: retain search table settings and order #281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested as much as I could and works great. I left a few inline comments, none of which are crucial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looking really good! made one minor request
Thanks for your review and insights!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR implements changes to retain the sorting and pagination information in the explorer results tables. These changes allow the navigation back to the tables, preserving the user's preferred sorting order and the selected tab and pagination. The main changes introduced with this PR are:
Persistent sorting: The sorting order for the columns is now saved and reapplied when navigating back to the explorer result tables
Saved pagination state: The current page is stored and retrieved when returning to the tables, keeping the user's position in the dataset.
Redux integration: Updated the redux actions and state to handle the storing and retrieval of sorting and pagination information, making it accessible across different components.
Code refactoring: Refactored the code including the implementation of custom sorting hook and the ExplorerSearchResultsTable component.