Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13] fix: retain search table settings and order #281

Merged
merged 28 commits into from
Aug 28, 2023
Merged

[13] fix: retain search table settings and order #281

merged 28 commits into from
Aug 28, 2023

Conversation

noctillion
Copy link
Contributor

This PR implements changes to retain the sorting and pagination information in the explorer results tables. These changes allow the navigation back to the tables, preserving the user's preferred sorting order and the selected tab and pagination. The main changes introduced with this PR are:

Persistent sorting: The sorting order for the columns is now saved and reapplied when navigating back to the explorer result tables

Saved pagination state: The current page is stored and retrieved when returning to the tables, keeping the user's position in the dataset.

Redux integration: Updated the redux actions and state to handle the storing and retrieval of sorting and pagination information, making it accessible across different components.

Code refactoring: Refactored the code including the implementation of custom sorting hook and the ExplorerSearchResultsTable component.

@noctillion
Update URL parameters to reflect active tab
af90d14
@noctillion
Include datasetId as
a3920ed 
props for result tables component
@noctillion
Import history hooks
06b1de4
@noctillion
Reset colum order for
0c7d6a2 
result tables
@noctillion
Implement actions for set and
2035b14 
reset result table sorting
@noctillion
Implement reducer for set ans reset
79cedbd 
explorer results table sort
@noctillion
remove log
95acfed
@noctillion
Implement hooks for explorer reults tables
86a477b
@noctillion
Implements column sort tracking
0ad6f84 
fron individuals table
@noctillion
Implements column sort tracking
f2999a2 
for biosample table
@noctillion
Implements column sort tracking
ba14aba 
for experimets table
@noctillion
Handle back navigation by updating state and URL
3eb1a21
@noctillion
Initialize sorted info with useMemo
86187df
@noctillion
Implement action for set active tab
9ada540
@noctillion
Implement reducer for set active tab
ac2ae1a
@noctillion
Update explorer hooks
7838aab
@noctillion
Implement set active tab to redux state
4484f94
@noctillion
Update tab persistace mechanish
a6f8ffe
@noctillion
Revert "Update URL parameters to reflect active tab"
fb48694 
This reverts commit af90d14.
@noctillion
Revert "Import history hooks"
8d9122f 
This reverts commit 06b1de4.
@noctillion
Merge branch 'bug/retain_search_table_setting_order_tab' into bug/ret…
50b2804 
…ain_search_table_setting_order
@noctillion
Remove typo
ffe0943
@noctillion
Reset tab selection with a new search
65c0670
@davidlougheed davidlougheed changed the title Bug/retain_search_table_setting_order fix: retain search table settings and order Aug 16, 2023
@noctillion noctillion marked this pull request as ready for review August 21, 2023 13:57
@noctillion noctillion requested a review from gsfk August 21, 2023 14:13
gsfk
gsfk approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@gsfk gsfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested as much as I could and works great. I left a few inline comments, none of which are crucial.

src/components/explorer/hooks/explorerHooks.js Outdated Show resolved Hide resolved
src/components/explorer/ExplorerIndividualContent.js Outdated Show resolved Hide resolved
src/components/explorer/ExplorerSearchResultsTable.js Outdated Show resolved Hide resolved
davidlougheed
davidlougheed requested changes Aug 26, 2023
View reviewed changes
Copy link
Member

@davidlougheed davidlougheed left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looking really good! made one minor request

src/components/explorer/ExplorerDatasetSearch.js Show resolved Hide resolved
src/components/explorer/ExplorerSearchResultsTable.js Outdated Show resolved Hide resolved
@noctillion
Copy link
Contributor Author

Thanks for your review and insights!!

@davidlougheed davidlougheed changed the title fix: retain search table settings and order [13] fix: retain search table settings and order Aug 28, 2023
davidlougheed
davidlougheed approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davidlougheed davidlougheed merged commit 558dc08 into master Aug 28, 2023
3 checks passed
@davidlougheed davidlougheed deleted the bug/retain_search_table_setting_order branch August 28, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlougheed davidlougheed davidlougheed approved these changes

@gsfk gsfk gsfk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noctillion @davidlougheed @gsfk